Use the grpc response as the source of truth for update graph data #1105
Conversation
openshift-ci-robot
added
approved
openshift-ci-robot
added
size/L
|
/retest |
1 similar comment
|
/retest |
openshift-ci-robot
added
size/XXL
| @@ -238,18 +238,14 @@ type Operator struct { | |||
|
|
|||
| var _ OperatorSurface = &Operator{} | |||
|
|
|||
| func NewOperatorFromBundle(bundle *api.Bundle, replaces string, startingCSV string, sourceKey CatalogKey) (*Operator, error) { | |||
| func NewOperatorFromBundle(bundle *api.Bundle, startingCSV string, sourceKey CatalogKey) (*Operator, error) { | |||
There was a problem hiding this comment.
Just asking because I don't know how this works very well:
since the replaces field in the db is an int64 and what is used here is a string that is the equivalent of the replaces field in the csv - does the o.Identifier() extract that replaces csv name from the database/query?
There was a problem hiding this comment.
The values from replaces in the registry isn't seen by olm at all.
OLM queries for a replacement with FindReplacement, and uses whatever the registry returns as the value for the "replaces" field that it puts in the CSV.
|
/lgtm |
|
/retest |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
/retest
|
|
/retest |
instead, updates should be simulated - in this case, by switching to a channel that contains an update.
|
/retest |
|
/retest |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, gallettilance, jpeeler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of the change:
This trusts the values coming from the registry pod to determine what an operator replaces.
It also removes the remaining places that csvs needed to be parsed during resolution.
Depends on operator-framework/operator-registry#113 and will need to be updated when it merges.
Motivation for the change:
This allows us to change how the graph is generated in the future.
Reviewer Checklist
/docs