Bug 1781366: feat(resolver): fallback to csv parsing if grcp api does not contain info #1194
Conversation
openshift-ci-robot
added
approved
ecordell
changed the title
|
@ecordell: This pull request references Bugzilla bug 1781366, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
ecordell
force-pushed
the
csv-fallback
branch
from
fc35090 to
35ab1f9
Compare
the information required
ecordell
force-pushed
the
csv-fallback
branch
from
35ab1f9 to
a106f7c
Compare
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@ecordell: This pull request references Bugzilla bug 1781366, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
| } | ||
|
|
||
| // legacy support - if the grpc api doesn't contain the information we need, fallback to csv parsing | ||
| if len(required) == 0 && len(provided) == 0 { |
There was a problem hiding this comment.
Just a thought -- but if JSONPath can let us query the provided and required APIs w/o unmarshaling the entire CSV, should we use it to more accurately verify the content of the bundle fields?
(this question shouldn't block the PR)
There was a problem hiding this comment.
I was thinking that if the grpc has any provide/required apis, we just trust that (gives us more freedom on the side of the registry going forward).
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, kevinrizza, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@spadgett Seeing some more console e2e failures here. |
|
/retest |
|
/hold cancel |
|
@ecordell: All pull requests linked via external trackers have merged. Bugzilla bug 1781366 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.3 |
|
@ecordell: new pull request created: #1195 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of the change:
Falls back to parsing the CSV in the grpc api response if expected fields are not present.
Motivation for the change:
Recent changes to the grpc api pulls out information from the CSV on load time via OPM and shares it. OLM is looking in those new fields to find it. If an older registry is used against a newer OLM, OLM will see packages that have no required/provided apis and will fail to resolve dependencies.
No official content was ever shipped with this combination, but users building their own custom catalogs will hit this.
Note: this change is also included in #1105
Reviewer Checklist
/docs