Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beta.kubernetes.io/os deprecated since v1.14, removed in v1.19 #1562

Merged
merged 1 commit into from
Jun 11, 2020
Merged

beta.kubernetes.io/os deprecated since v1.14, removed in v1.19 #1562

merged 1 commit into from
Jun 11, 2020

Conversation

kramvan1
Copy link
Contributor

@kramvan1 kramvan1 commented Jun 1, 2020 •
edited
Loading

Description of the change:

Switch to supported os node selector, beta one is deprecated AND removed now.

Motivation for the change:

kubernetes/kubernetes#89460

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@kramvan1
beta.kubernetes.io/os deprecated since v1.14, removed in v1.19
5ffe1d3 
**Description of the change:**

Switch to supported os node selector, beta one is deprecated AND removed now.

**Motivation for the change:**

kubernetes/kubernetes#89460

**Reviewer Checklist**
- [x] Implementation matches the proposed design, or proposal is updated to match implementation
- [x] Sufficient unit test coverage
- [x] Sufficient end-to-end test coverage
- [x] Docs updated or added to `/docs`
- [x] Commit messages sensible and descriptive
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 1, 2020
@openshift-ci-robot
Copy link
Collaborator

Hi @kramvan1. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kramvan1
Copy link
Contributor Author

kramvan1 commented Jun 1, 2020

/assign @ecordell
@ecordell Hi, this is now needed for kube 1.19, as the old beta value has now been removed from kube.

@Bowenislandsong
Copy link
Member

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 2, 2020
@kramvan1
Copy link
Contributor Author

kramvan1 commented Jun 2, 2020

/retest

@kramvan1
Copy link
Contributor Author

kramvan1 commented Jun 2, 2020

@ecordell @Bowenislandsong Could use a bit of help on why these tests are failing, I'm not as familiar with them. Was hoping this was going to be a simple change, no logic was changed.

@exdx
Copy link
Member

exdx commented Jun 4, 2020

/retest
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2020
@exdx
Copy link
Member

exdx commented Jun 4, 2020

@ecordell @Bowenislandsong Could use a bit of help on why these tests are failing, I'm not as familiar with them. Was hoping this was going to be a simple change, no logic was changed.

Our tests flake with some regularity - sometimes it's instability on the cloud provider side. Your changes look to be fine and we appreciate the contribution

@kramvan1
Copy link
Contributor Author

kramvan1 commented Jun 8, 2020

/retest

1 similar comment
@kramvan1
Copy link
Contributor Author

kramvan1 commented Jun 8, 2020

/retest

@kramvan1
Copy link
Contributor Author

kramvan1 commented Jun 9, 2020

@exdx Hi, tried retest a couple times, not sure how many to do. Any thoughts on this failure?

@exdx
Copy link
Member

exdx commented Jun 9, 2020

@exdx Hi, tried retest a couple times, not sure how many to do. Any thoughts on this failure?

Looks like the upstream e2e test is consistently failing so there must be an issue with our e2e tests. I'm going to pull this branch down and see if they pass.

@exdx
Copy link
Member

exdx commented Jun 9, 2020

/retest

Looking at this more, I don't see any issues why the new node selectors would cause the tests to fail - the new selector is already present on all nodes in the cluster. The upstream e2e also passed. We can continue testing the openshift aws e2e and it will pass eventually I believe.

@kramvan1
Copy link
Contributor Author

kramvan1 commented Jun 9, 2020

@exdx thx for the help here, we keep retesting for a while.

@kramvan1
Copy link
Contributor Author

kramvan1 commented Jun 9, 2020

/retest

@ecordell
Copy link
Member

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, kramvan1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2020
@ecordell
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@Bowenislandsong
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 21d67c1 into operator-framework:master Jun 11, 2020
@kramvan1 kramvan1 deleted the remove-deprecated-os-label branch June 15, 2020 16:16
@kramvan1 kramvan1 mentioned this pull request Jul 21, 2020
Closed
@rtheis rtheis mentioned this pull request Jul 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benluddy benluddy Awaiting requested review from benluddy

@Bowenislandsong Bowenislandsong Awaiting requested review from Bowenislandsong

Assignees

@ecordell ecordell

@exdx exdx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kramvan1 @openshift-ci-robot @Bowenislandsong @exdx @ecordell @openshift-bot @openshift-merge-robot