Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beta.kubernetes.io/os deprecated since v1.14, removed in v1.19 #1562

Merged
merged 1 commit into from
Jun 11, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions deploy/chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ olm:
service:
internalPort: 8080
nodeSelector:
beta.kubernetes.io/os: linux
kubernetes.io/os: linux
resources:
requests:
cpu: 10m
Expand All @@ -30,7 +30,7 @@ catalog:
service:
internalPort: 8080
nodeSelector:
beta.kubernetes.io/os: linux
kubernetes.io/os: linux
resources:
requests:
cpu: 10m
Expand All @@ -44,7 +44,7 @@ package:
service:
internalPort: 5443
nodeSelector:
beta.kubernetes.io/os: linux
kubernetes.io/os: linux
resources:
requests:
cpu: 10m
Expand Down
6 changes: 3 additions & 3 deletions deploy/ocp/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ olm:
service:
internalPort: 8080
nodeSelector:
beta.kubernetes.io/os: linux
kubernetes.io/os: linux
node-role.kubernetes.io/master: ""
tolerations:
- key: node-role.kubernetes.io/master
Expand Down Expand Up @@ -43,7 +43,7 @@ catalog:
service:
internalPort: 8080
nodeSelector:
beta.kubernetes.io/os: linux
kubernetes.io/os: linux
node-role.kubernetes.io/master: ""
tolerations:
- key: node-role.kubernetes.io/master
Expand All @@ -69,7 +69,7 @@ package:
service:
internalPort: 5443
nodeSelector:
beta.kubernetes.io/os: linux
kubernetes.io/os: linux
node-role.kubernetes.io/master: ""
tolerations:
- key: node-role.kubernetes.io/master
Expand Down
18 changes: 9 additions & 9 deletions deploy/upstream/quickstart/olm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11696,7 +11696,7 @@ spec:
port: 8080
terminationMessagePolicy: FallbackToLogsOnError
env:

- name: OPERATOR_NAMESPACE
valueFrom:
fieldRef:
Expand All @@ -11707,10 +11707,10 @@ spec:
requests:
cpu: 10m
memory: 160Mi


nodeSelector:
beta.kubernetes.io/os: linux
kubernetes.io/os: linux
---
apiVersion: apps/v1
kind: Deployment
Expand Down Expand Up @@ -11759,15 +11759,15 @@ spec:
port: 8080
terminationMessagePolicy: FallbackToLogsOnError
env:

resources:
requests:
cpu: 10m
memory: 80Mi


nodeSelector:
beta.kubernetes.io/os: linux
kubernetes.io/os: linux
---
kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1
Expand Down Expand Up @@ -11896,7 +11896,7 @@ spec:
spec:
serviceAccountName: olm-operator-serviceaccount
nodeSelector:
beta.kubernetes.io/os: linux
kubernetes.io/os: linux
containers:
- name: packageserver
command:
Expand Down
4 changes: 2 additions & 2 deletions doc/design/building-your-csv.md
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ An APIService is uniquely identified by the group-version it provides and can be
**Kind**: A kind that the APIService is expected to provide.

**DeploymentName**:
Name of the deployment defined by your CSV that corresponds to your APIService (required for owned APIServices). During the CSV pending phase, the OLM Operator will search your CSV's InstallStrategy for a deployment spec with a matching name, and if not found, will not transition the CSV to the install ready phase.
Name of the deployment defined by your CSV that corresponds to your APIService (required for owned APIServices). During the CSV pending phase, the OLM Operator will search your CSV's InstallStrategy for a deployment spec with a matching name, and if not found, will not transition the CSV to the install ready phase.

**Resources**:
Your APIServices will own one or more types of Kubernetes objects. These are listed in the resources section to inform your end-users of the objects they might need to troubleshoot or how to connect to the application, such as the Service or Ingress rule that exposes a database.
Expand Down Expand Up @@ -345,7 +345,7 @@ Here’s a full example:
imagePullSecrets:
- name: ''
nodeSelector:
beta.kubernetes.io/os: linux
kubernetes.io/os: linux
serviceAccountName: example-operator
permissions:
- serviceAccountName: example-operator
Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/registry/reconciler/reconciler.go
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ func Pod(source *v1alpha1.CatalogSource, name string, image string, labels map[s
},
},
NodeSelector: map[string]string{
"beta.kubernetes.io/os": "linux",
"kubernetes.io/os": "linux",
},
},
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/registry/reconciler/reconciler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ func TestPodNodeSelector(t *testing.T) {
},
}

key := "beta.kubernetes.io/os"
key := "kubernetes.io/os"
value := "linux"

gotCatSrcPod := Pod(catsrc, "hello", "busybox", map[string]string{}, int32(0), int32(0))
Expand Down
4 changes: 2 additions & 2 deletions pkg/package-server/provider/registry_test.go

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ spec:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: true
nodeSelector:
beta.kubernetes.io/os: linux
kubernetes.io/os: linux
maturity: beta
version: 0.22.2
customresourcedefinitions:
Expand Down