[release-4.7] OCPBUGS-741: Remove outdated subscription update logic to improve resolution delay #2856

perdasilva · 2022-09-13T07:20:36Z

Currently, olm logic checks for upgrade in subscription via another obsolete API that is no longer in use for dependency solution. As a result, sometimes, subscriptions display UpgradeAvailable status but there will be no upgrades as the upgrade is not valid in the resolver. Also, the UpgradeAvailable status is used to trigger the new resolution even though that status is no longer a valid indicator of having a pending upgrade. This leads to unwanted upgrade delay when the obsolete API works properly.

This commit will remove the code that is using this obsolete API and allow the resolution to happen when there is a subscription change.

Signed-off-by: Vu Dinh vudinh@outlook.com

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

openshift-ci · 2022-09-13T07:20:40Z

@perdasilva: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

BugFix (OCPBUGS-741): Remove oudated subscription update logic to improve resolution delay

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…perator-framework#2369) Currently, olm logic checks for upgrade in subscription via another obsolete API that is no longer in use for dependency solution. As a result, sometimes, subscriptions display `UpgradeAvailable` status but there will be no upgrades as the upgrade is not valid in the resolver. Also, the `UpgradeAvailable` status is used to trigger the new resolution even though that status is no longer a valid indicator of having a pending upgrade. This leads to unwanted upgrade delay when the obsolete API works properly. This commit will remove the code that is using this obsolete API and allow the resolution to happen when there is a subscription change. Signed-off-by: Vu Dinh <vudinh@outlook.com> Signed-off-by: perdasilva <perdasilva@redhat.com>

openshift-ci · 2022-09-13T07:46:00Z

@perdasilva: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

BugFix OCPBUGS-741: Remove oudated subscription update logic to improve resolution delay

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-09-13T07:46:01Z

@perdasilva: This pull request references Jira Issue OCPBUGS-741, which is invalid:

expected dependent Jira Issue OCPBUGS-740 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is Closed (Done-Errata) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Currently, olm logic checks for upgrade in subscription via another obsolete API that is no longer in use for dependency solution. As a result, sometimes, subscriptions display UpgradeAvailable status but there will be no upgrades as the upgrade is not valid in the resolver. Also, the UpgradeAvailable status is used to trigger the new resolution even though that status is no longer a valid indicator of having a pending upgrade. This leads to unwanted upgrade delay when the obsolete API works properly.

This commit will remove the code that is using this obsolete API and allow the resolution to happen when there is a subscription change.

Signed-off-by: Vu Dinh vudinh@outlook.com

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

Implementation matches the proposed design, or proposal is updated to match implementation

Sufficient unit test coverage

Sufficient end-to-end test coverage

Bug fixes are accompanied by regression test(s)

e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times

tech debt/todo is accompanied by issue link(s) in comments in the surrounding code

Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately

Docs updated or added to /doc

Commit messages sensible and descriptive

Tests marked as [FLAKE] are truly flaky and have an issue

Code is properly formatted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-09-13T11:19:37Z

/retest-required

perdasilva · 2022-09-14T12:06:58Z

/retest

perdasilva · 2022-09-14T14:24:42Z

/jira refresh

openshift-ci-robot · 2022-09-14T14:24:45Z

@perdasilva: This pull request references Jira Issue OCPBUGS-741, which is invalid:

expected the bug to be open, but it isn't
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done) instead
expected dependent Jira Issue OCPBUGS-740 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is Closed (Done-Errata) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-09-14T14:25:39Z

/jira refresh

openshift-ci-robot · 2022-09-14T14:25:41Z

@perdasilva: This pull request references Jira Issue OCPBUGS-741, which is invalid:

expected dependent Jira Issue OCPBUGS-740 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is Closed (Done-Errata) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-09-14T14:27:36Z

/override jira/invalid-bug

openshift-ci · 2022-09-14T14:27:40Z

@perdasilva: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

jira/invalid-bug

Only the following failed contexts/checkruns were expected:

ci/prow/e2e-aws-console-olm
ci/prow/e2e-aws-olm
ci/prow/e2e-gcp
ci/prow/e2e-upgrade
ci/prow/images
ci/prow/unit
ci/prow/verify
pull-ci-operator-framework-operator-lifecycle-manager-release-3.11-images
pull-ci-operator-framework-operator-lifecycle-manager-release-3.11-unit
pull-ci-operator-framework-operator-lifecycle-manager-release-3.11-verify
pull-ci-operator-framework-operator-lifecycle-manager-release-4.1-e2e-aws-console-olm
pull-ci-operator-framework-operator-lifecycle-manager-release-4.1-e2e-aws-olm
pull-ci-operator-framework-operator-lifecycle-manager-release-4.3-e2e-gcp
pull-ci-operator-framework-operator-lifecycle-manager-release-4.3-e2e-upgrade
tide

In response to this:

/override jira/invalid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-09-15T06:48:00Z

/retest

perdasilva · 2022-09-16T15:54:44Z

/retest

perdasilva · 2022-09-19T07:24:07Z

/retest

timflannagan · 2022-09-20T20:19:41Z

/retitle [release-4.7] OCPBUGS-741: Remove outdated subscription update logic to improve resolution delay

openshift-ci · 2022-09-20T20:19:45Z

@perdasilva: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.7] OCPBUGS-741: Remove outdated subscription update logic to improve resolution delay

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-09-20T20:21:58Z

@timflannagan: This pull request references Jira Issue OCPBUGS-741, which is invalid:

expected dependent Jira Issue OCPBUGS-740 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is Closed (Done-Errata) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Retaining the jira/valid-bug label as it was manually added.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-09-21T14:24:04Z

/retest

perdasilva · 2022-09-22T07:24:40Z

/retest

perdasilva · 2022-09-22T15:58:43Z

/retest

perdasilva · 2022-10-03T10:14:11Z

/retest

exdx · 2022-10-06T02:19:57Z

/retest

perdasilva · 2022-10-06T14:16:27Z

/retest

perdasilva · 2022-10-14T13:24:35Z

/label backport-risk-assessed

perdasilva · 2022-10-14T13:25:40Z

/retest

timflannagan · 2022-10-14T13:32:19Z

/lgtm
/uncc

perdasilva · 2022-11-14T08:54:25Z

/retest

perdasilva · 2022-11-15T16:14:23Z

overriding e2e test job since over multiple runs there's no consistency in the failures. I've manually verified that all e2e tests succeed on my machine

perdasilva · 2022-11-15T16:14:43Z

/override ci/prow/e2e-aws-olm

openshift-ci · 2022-11-15T16:14:48Z

@perdasilva: Overrode contexts on behalf of perdasilva: ci/prow/e2e-aws-olm

In response to this:

/override ci/prow/e2e-aws-olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jianzhangbjz · 2022-11-22T11:03:31Z

/label cherry-pick-approve

openshift-ci · 2022-11-22T11:03:33Z

@jianzhangbjz: The label(s) /label cherry-pick-approve cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label cherry-pick-approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jianzhangbjz · 2022-11-22T11:03:50Z

/label cherry-pick-approved

openshift-ci · 2022-11-22T11:04:05Z

@jianzhangbjz: Can not set label cherry-pick-approved: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers]

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jianzhangbjz · 2022-11-22T11:55:52Z

/label cherry-pick-approved

awgreene · 2022-11-22T14:15:30Z

/approve
Eric requested this be backported all the way to 4.6

openshift-ci · 2022-11-22T14:15:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [awgreene]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2022-11-22T14:20:02Z

@perdasilva: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/operator-framework-olm#373 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-741 has not been moved to the MODIFIED state.

In response to this:

Currently, olm logic checks for upgrade in subscription via another obsolete API that is no longer in use for dependency solution. As a result, sometimes, subscriptions display UpgradeAvailable status but there will be no upgrades as the upgrade is not valid in the resolver. Also, the UpgradeAvailable status is used to trigger the new resolution even though that status is no longer a valid indicator of having a pending upgrade. This leads to unwanted upgrade delay when the obsolete API works properly.

This commit will remove the code that is using this obsolete API and allow the resolution to happen when there is a subscription change.

Signed-off-by: Vu Dinh vudinh@outlook.com

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

Implementation matches the proposed design, or proposal is updated to match implementation

Sufficient unit test coverage

Sufficient end-to-end test coverage

Bug fixes are accompanied by regression test(s)

e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times

tech debt/todo is accompanied by issue link(s) in comments in the surrounding code

Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately

Docs updated or added to /doc

Commit messages sensible and descriptive

Tests marked as [FLAKE] are truly flaky and have an issue

Code is properly formatted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from ecordell and hasbro17 September 13, 2022 07:20

perdasilva force-pushed the OCPBUGS-741 branch from 0a5cb84 to e34aa22 Compare September 13, 2022 07:20

perdasilva force-pushed the OCPBUGS-741 branch from e34aa22 to e7cddf7 Compare September 13, 2022 07:22

perdasilva mentioned this pull request Sep 13, 2022

[release-4.6] OCPBUGS-1176: Remove outdated subscription update logic to improve resolution delay #2857

Closed

11 tasks

perdasilva changed the title ~~BugFix (OCPBUGS-741): Remove oudated subscription update logic to improve resolution delay~~ BugFix OCPBUGS-741: Remove oudated subscription update logic to improve resolution delay Sep 13, 2022

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 13, 2022

openshift-ci bot changed the title ~~BugFix OCPBUGS-741: Remove oudated subscription update logic to improve resolution delay~~ [release-4.7] OCPBUGS-741: Remove outdated subscription update logic to improve resolution delay Sep 20, 2022

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 20, 2022

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 14, 2022

openshift-ci bot assigned timflannagan Oct 14, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2022

jianzhangbjz mentioned this pull request Nov 22, 2022

add cherry-pick-approved for upstream OLM openshift/release#34216

Merged

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 22, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2022

openshift-merge-robot merged commit da9d438 into operator-framework:release-4.7 Nov 22, 2022

[release-4.7] OCPBUGS-741: Remove outdated subscription update logic to improve resolution delay #2856

[release-4.7] OCPBUGS-741: Remove outdated subscription update logic to improve resolution delay #2856

Conversation

perdasilva commented Sep 13, 2022

openshift-ci bot commented Sep 13, 2022

openshift-ci bot commented Sep 13, 2022

openshift-ci-robot commented Sep 13, 2022

perdasilva commented Sep 13, 2022

perdasilva commented Sep 14, 2022

perdasilva commented Sep 14, 2022

openshift-ci-robot commented Sep 14, 2022

perdasilva commented Sep 14, 2022

openshift-ci-robot commented Sep 14, 2022

perdasilva commented Sep 14, 2022

openshift-ci bot commented Sep 14, 2022

perdasilva commented Sep 15, 2022

perdasilva commented Sep 16, 2022

perdasilva commented Sep 19, 2022

timflannagan commented Sep 20, 2022

openshift-ci bot commented Sep 20, 2022

openshift-ci-robot commented Sep 20, 2022

perdasilva commented Sep 21, 2022

perdasilva commented Sep 22, 2022

perdasilva commented Sep 22, 2022

perdasilva commented Oct 3, 2022

exdx commented Oct 6, 2022

perdasilva commented Oct 6, 2022

perdasilva commented Oct 14, 2022

perdasilva commented Oct 14, 2022

timflannagan commented Oct 14, 2022

perdasilva commented Nov 14, 2022

perdasilva commented Nov 15, 2022

perdasilva commented Nov 15, 2022

openshift-ci bot commented Nov 15, 2022

jianzhangbjz commented Nov 22, 2022

openshift-ci bot commented Nov 22, 2022

jianzhangbjz commented Nov 22, 2022

openshift-ci bot commented Nov 22, 2022

jianzhangbjz commented Nov 22, 2022

awgreene commented Nov 22, 2022

openshift-ci bot commented Nov 22, 2022

openshift-ci-robot commented Nov 22, 2022