Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Missing Fields in Subscription status.installPlan #355

Closed
wants to merge 1 commit into from
Closed

Fix Missing Fields in Subscription status.installPlan #355

wants to merge 1 commit into from

Conversation

alecmerdler
Copy link
Member

Description

Must be caused by CRDs + codegen problems.

Fixes https://jira.coreos.com/browse/ALM-586

@alecmerdler alecmerdler added kind/bug Categorizes issue or PR as related to a bug. internal/tracked This issue is tracked in the internal JIRA labels May 21, 2018
@alecmerdler alecmerdler requested a review from ecordell May 21, 2018 20:02
ecordell
ecordell approved these changes May 22, 2018
View reviewed changes
Copy link
Member

@ecordell ecordell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

we should see if there's an upstream issue for this codegen problem and make one if not

(alternatively, maybe we just didn't specify one of the necessary tags)

ecordell
ecordell requested changes May 22, 2018
View reviewed changes
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if we can figure out the root cause here

@alecmerdler
Copy link
Member Author

Closed in favor of #359

@alecmerdler alecmerdler deleted the ALM-586 branch May 28, 2018 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecordell ecordell ecordell requested changes

Assignees
No one assigned
Labels
internal/tracked This issue is tracked in the internal JIRA kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alecmerdler @ecordell