-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix InstallPlanReference in Subscription Status #359
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecordell
force-pushed
the
fix-uid
branch
2 times, most recently
from
May 25, 2018 21:07
aecc6a3
to
1ff533e
Compare
ecordell
added
kind/bug
Categorizes issue or PR as related to a bug.
internal/tracked
This issue is tracked in the internal JIRA
and removed
do not merge
labels
May 25, 2018
ecordell
changed the title
WIP: Fix GetUID
Fix InstallPlanReference in Subscription Status
May 25, 2018
How did you figure this out? |
k8s resources only have TypeMeta when serialized, so pull in the apiversion and kind of the resolved installplan of the type we created
alecmerdler
previously approved these changes
May 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
alecmerdler
approved these changes
May 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
njhale
pushed a commit
to njhale/operator-lifecycle-manager
that referenced
this pull request
Sep 10, 2018
Fix InstallPlanReference in Subscription Status
ecordell
added a commit
to ecordell/operator-lifecycle-manager
that referenced
this pull request
Mar 8, 2019
Fix InstallPlanReference in Subscription Status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
internal/tracked
This issue is tracked in the internal JIRA
kind/bug
Categorizes issue or PR as related to a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeMeta is only applied at serialization time, so we should just write out the apiversion/kind of the clients that we know we used.