Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InstallPlanReference in Subscription Status #359

Merged
merged 3 commits into from
May 29, 2018

Conversation

ecordell
Copy link
Member

@ecordell ecordell commented May 25, 2018

TypeMeta is only applied at serialization time, so we should just write out the apiversion/kind of the clients that we know we used.

@ecordell ecordell force-pushed the fix-uid branch 2 times, most recently from aecc6a3 to 1ff533e Compare May 25, 2018 21:07
@ecordell ecordell requested a review from alecmerdler May 25, 2018 21:33
@ecordell ecordell added kind/bug Categorizes issue or PR as related to a bug. internal/tracked This issue is tracked in the internal JIRA and removed do not merge labels May 25, 2018
@ecordell ecordell changed the title WIP: Fix GetUID Fix InstallPlanReference in Subscription Status May 25, 2018
@alecmerdler
Copy link
Member

How did you figure this out?

k8s resources only have TypeMeta when serialized, so pull in the
apiversion and kind of the resolved installplan of the type we created
alecmerdler
alecmerdler previously approved these changes May 29, 2018
Copy link
Member

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecordell ecordell merged commit 7f2f14b into operator-framework:master May 29, 2018
@ecordell ecordell deleted the fix-uid branch May 29, 2018 19:18
njhale pushed a commit to njhale/operator-lifecycle-manager that referenced this pull request Sep 10, 2018
Fix InstallPlanReference in Subscription Status
ecordell added a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
Fix InstallPlanReference in Subscription Status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal/tracked This issue is tracked in the internal JIRA kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants