Verify CRD's condition to ensure it's registered with k8s API #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/S
|
/approve looks good! just need some tests for this. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
dinhxuanvu
force-pushed
the
crd-ready-check
branch
from
72b268e to
8b1152a
Compare
openshift-ci-robot
added
size/M
dinhxuanvu
force-pushed
the
crd-ready-check
branch
from
8b1152a to
11871b4
Compare
Miciah
reviewed
Nov 12, 2018
openshift-ci-robot
added
size/L
dinhxuanvu
force-pushed
the
crd-ready-check
branch
5 times, most recently
from
2147ca1 to
aa11b8d
Compare
dinhxuanvu
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
dinhxuanvu
force-pushed
the
crd-ready-check
branch
3 times, most recently
from
6e6c421 to
6036829
Compare
dinhxuanvu
force-pushed
the
crd-ready-check
branch
3 times, most recently
from
fc4ff15 to
27384a6
Compare
dinhxuanvu
force-pushed
the
crd-ready-check
branch
2 times, most recently
from
51174ae to
48c15c1
Compare
|
/test e2e-aws |
dinhxuanvu
force-pushed
the
crd-ready-check
branch
from
48c15c1 to
56cad87
Compare
ecordell
requested changes
Nov 26, 2018
dinhxuanvu
force-pushed
the
crd-ready-check
branch
3 times, most recently
from
f0d4823 to
12476aa
Compare
|
/test unit |
openshift-ci-robot
added
the
needs-rebase
dinhxuanvu
force-pushed
the
crd-ready-check
branch
from
12476aa to
4060936
Compare
openshift-ci-robot
removed
the
needs-rebase
dinhxuanvu
force-pushed
the
crd-ready-check
branch
3 times, most recently
from
458bc85 to
917c872
Compare
|
/retest |
|
@dinhxuanvu I think you need to rebase, but then this PR should be good to go |
dinhxuanvu
force-pushed
the
crd-ready-check
branch
from
917c872 to
79bedae
Compare
|
/retest |
OLM needs to verify CRD's condition to make sure it is registered with k8s API during CSV control loop before installing operator. This verification will help to avoid errors related to the unavailability of an API when installing an operator via OLM. Jira: https://jira.coreos.com/browse/ALM-775 Signed-off-by: Vu Dinh <vdinh@redhat.com>
ecordell
force-pushed
the
crd-ready-check
branch
from
79bedae to
a75c00f
Compare
|
@dinhxuanvu: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Since the PR from my branch is all green, I'm closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OLM needs to verify CRD's condition to make sure it is registered
with k8s API during CSV control loop before installing operator.
This verification will help to avoid errors related to the
unavailability of an API when installing an operator via OLM.
Jira: https://jira.coreos.com/browse/ALM-775
Signed-off-by: Vu Dinh vdinh@redhat.com