Verify CRD's condition to ensure it's registered with k8s API (rebased) #614
Conversation
OLM needs to verify CRD's condition to make sure it is registered with k8s API during CSV control loop before installing operator. This verification will help to avoid errors related to the unavailability of an API when installing an operator via OLM. Jira: https://jira.coreos.com/browse/ALM-775 Signed-off-by: Vu Dinh <vdinh@redhat.com>
This allows log level changes in the unit tests to be respected. Also, change operator groups default level to debug.
openshift-ci-robot
added
the
size/L
|
Copied from old PR: OLM needs to verify CRD's condition to make sure it is registered |
| namespace, | ||
| "", | ||
| installStrategy("csv1-dep", nil, nil), | ||
| []*v1beta1.CustomResourceDefinition{crdWithoutStatus("c1", "v2")}, |
There was a problem hiding this comment.
I think I'm missing what makes this CRD be unavailable? What's the difference between this test and the previous?
jpeeler
force-pushed
the
jeff-533
branch
2 times, most recently
from
9f13db7 to
7a4aaf0
Compare
Change the default `crd` function to return appropriate status as to pass the requirement checks. Also, make some minor logging improvements.
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpeeler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
| ), | ||
| existingObjs: nil, | ||
| existingExtObjs: []runtime.Object{ | ||
| func() *v1beta1.CustomResourceDefinition { |
|
/lgtm |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Verify CRD's condition to ensure it's registered with k8s API (rebased)
njhale
added
the
kind/feature
This is Vu's #553, but rebased and with tests passing (should be at least!). It has been modified from his original code slightly -
mainly instead of creating a crdWithStatus, instead uses crdWithoutStatus which required far less code modification.