Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump k8s to 1.25 #1024

Merged

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Sep 19, 2022

Signed-off-by: Austin Macdonald austin@redhat.com

I also switched the github actions to pull the go version from go.mod so we don't have to update all of them every golang bump. (Pulling go version from go.mod merged in #1025)

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #1024 (d179db5) into master (bd3c804) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head d179db5 differs from pull request most recent head 5b08e64. Consider uploading reports for the commit 5b08e64 to get more accurate results

@@            Coverage Diff             @@
##           master    #1024      +/-   ##
==========================================
+ Coverage   51.95%   51.96%   +0.01%     
==========================================
  Files         102      102              
  Lines        9215     9215              
==========================================
+ Hits         4788     4789       +1     
+ Misses       3514     3513       -1     
  Partials      913      913              
Impacted Files Coverage Δ
alpha/declcfg/declcfg.go 100.00% <ø> (ø)
alpha/model/model.go 92.64% <ø> (ø)
alpha/property/property.go 92.68% <ø> (ø)
pkg/lib/indexer/interfaces.go 0.00% <ø> (ø)
pkg/registry/query.go 61.48% <ø> (ø)
alpha/veneer/semver/semver.go 60.50% <0.00%> (+0.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@asmacdo asmacdo force-pushed the k8s-125-bump branch 2 times, most recently from e3c6709 to f93dbf7 Compare September 19, 2022 15:16
@laxmikantbpandhare
Copy link
Member

go-apidiff errors are expected ones.

@laxmikantbpandhare
Copy link
Member

This has to do with gofmt updates related to bumping the Go version to Go 1.19.

If you take a look at the Headings section of this documentation https://tip.golang.org/doc/comment you can see that as of Go 1.19 the new heading format is similar to Markdown and uses the # prefix:

@asmacdo
Copy link
Member Author

asmacdo commented Sep 20, 2022

/retest

@jmrodri
Copy link
Member

jmrodri commented Sep 20, 2022

/test unit

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2022

@jmrodri: No presubmit jobs available for operator-framework/operator-registry@master

In response to this:

/test unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@grokspawn grokspawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but since you retreated from the position of adjusting workflows to pull go version from go.mod, it would be nice if you edited the PR desc ... it got my hopes up when I saw you using go-version-file... but alas, it was not to be.

I understand if you'd like that to happen separately from this PR, but I was able to get it working in #1025

Edit: Spoke to Austin last Friday and he was going to rebase to pick up those changes once they merged.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2022
Copy link
Contributor

@timflannagan timflannagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once this is rebased.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asmacdo, grokspawn, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2022
Signed-off-by: Austin Macdonald <austin@redhat.com>
github.com/operator-framework/api v0.15.0
github.com/operator-framework/api v0.17.2-0.20220915200120-ff2dbc53d381
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an unrelated o-f/api psuedoversion?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to bump this version outside of these changes? It looks like there's been some API changes in the past couple of minor version releases, and we may need to be aware of any order of operation issues here.

@timflannagan
Copy link
Contributor

Ended up convincing myself that bumping o-f/api here should be relatively harmless, and I'm more concerned with doing due diligence when bumping that dependency in the OLM repository.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2022
@openshift-merge-robot openshift-merge-robot merged commit 6d762ad into operator-framework:master Sep 26, 2022
jcho02 pushed a commit to jcho02/operator-registry that referenced this pull request Sep 28, 2022
Signed-off-by: Austin Macdonald <austin@redhat.com>

Signed-off-by: Austin Macdonald <austin@redhat.com>
Signed-off-by: root <root@cineaste1.fyre.ibm.com>
aemperador pushed a commit to jcho02/operator-registry that referenced this pull request Sep 29, 2022
Signed-off-by: Austin Macdonald <austin@redhat.com>

Signed-off-by: Austin Macdonald <austin@redhat.com>
Signed-off-by: aemperador <alexis.emperador@ibm.com>
jcho02 pushed a commit to jcho02/operator-registry that referenced this pull request Sep 30, 2022
Signed-off-by: Austin Macdonald <austin@redhat.com>

Signed-off-by: Austin Macdonald <austin@redhat.com>
Signed-off-by: aemperador <alexis.emperador@ibm.com>
Signed-off-by: root <root@cineaste1.fyre.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants