-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump k8s to 1.25 #1024
bump k8s to 1.25 #1024
Conversation
7bdbefc
to
91f2509
Compare
Codecov Report
@@ Coverage Diff @@
## master #1024 +/- ##
==========================================
+ Coverage 51.95% 51.96% +0.01%
==========================================
Files 102 102
Lines 9215 9215
==========================================
+ Hits 4788 4789 +1
+ Misses 3514 3513 -1
Partials 913 913
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
e3c6709
to
f93dbf7
Compare
|
This has to do with gofmt updates related to bumping the Go version to Go 1.19. If you take a look at the Headings section of this documentation https://tip.golang.org/doc/comment you can see that as of Go 1.19 the new heading format is similar to Markdown and uses the # prefix: |
/retest |
/test unit |
@jmrodri: No presubmit jobs available for operator-framework/operator-registry@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker, but since you retreated from the position of adjusting workflows to pull go version from go.mod, it would be nice if you edited the PR desc ... it got my hopes up when I saw you using go-version-file... but alas, it was not to be.
I understand if you'd like that to happen separately from this PR, but I was able to get it working in #1025
Edit: Spoke to Austin last Friday and he was going to rebase to pick up those changes once they merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once this is rebased.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asmacdo, grokspawn, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f93dbf7
to
1a11966
Compare
Signed-off-by: Austin Macdonald <austin@redhat.com>
1a11966
to
5b08e64
Compare
github.com/operator-framework/api v0.15.0 | ||
github.com/operator-framework/api v0.17.2-0.20220915200120-ff2dbc53d381 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like an unrelated o-f/api psuedoversion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to bump this version outside of these changes? It looks like there's been some API changes in the past couple of minor version releases, and we may need to be aware of any order of operation issues here.
Ended up convincing myself that bumping o-f/api here should be relatively harmless, and I'm more concerned with doing due diligence when bumping that dependency in the OLM repository. /lgtm |
Signed-off-by: Austin Macdonald <austin@redhat.com> Signed-off-by: Austin Macdonald <austin@redhat.com> Signed-off-by: root <root@cineaste1.fyre.ibm.com>
Signed-off-by: Austin Macdonald <austin@redhat.com> Signed-off-by: Austin Macdonald <austin@redhat.com> Signed-off-by: aemperador <alexis.emperador@ibm.com>
Signed-off-by: Austin Macdonald <austin@redhat.com> Signed-off-by: Austin Macdonald <austin@redhat.com> Signed-off-by: aemperador <alexis.emperador@ibm.com> Signed-off-by: root <root@cineaste1.fyre.ibm.com>
Signed-off-by: Austin Macdonald austin@redhat.com
I also switched the github actions to pull the go version from go.mod so we don't have to update all of them every golang bump.(Pulling go version from go.mod merged in #1025)