Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating workflows to pull go version from go.mod file #1025

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

grokspawn
Copy link
Contributor

Description of the change:

Just playing with workflows

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 22, 2022
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #1025 (3d6b39f) into master (0e53caf) will not change coverage.
The diff coverage is n/a.

❗ Current head 3d6b39f differs from pull request most recent head 33f0b0e. Consider uploading reports for the commit 33f0b0e to get more accurate results

@@           Coverage Diff           @@
##           master    #1025   +/-   ##
=======================================
  Coverage   51.95%   51.95%           
=======================================
  Files         102      102           
  Lines        9215     9215           
=======================================
  Hits         4788     4788           
  Misses       3514     3514           
  Partials      913      913           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@grokspawn grokspawn changed the title WIP: testing workflows Updating workflows to pull go version from go.mod file Sep 23, 2022
@grokspawn grokspawn added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2022
@grokspawn grokspawn marked this pull request as ready for review September 23, 2022 16:01
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2022
@grokspawn grokspawn removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@timflannagan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2022
@openshift-merge-robot openshift-merge-robot merged commit bd3c804 into master Sep 23, 2022
@asmacdo asmacdo mentioned this pull request Sep 26, 2022
jcho02 pushed a commit to jcho02/operator-registry that referenced this pull request Oct 1, 2022
author Jordan Keister <jordan@nimblewidget.com> 1663950230 -0500
committer jcho02 <jason.cho2@ibm.com> 1664651189 -0700

Updating workflows to pull go version from go.mod file (operator-framework#1025)

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

go to 1.19

Signed-off-by: aemperador <alexis.emperador@ibm.com>
Signed-off-by: root <root@cineaste1.fyre.ibm.com>
Signed-off-by: jcho02 <jason.cho2@ibm.com>

go to 1.19

Signed-off-by: aemperador <alexis.emperador@ibm.com>
Signed-off-by: root <root@cineaste1.fyre.ibm.com>

upgrade to 1.19

Signed-off-by: aemperador <alexis.emperador@ibm.com>
Signed-off-by: root <root@cineaste1.fyre.ibm.com>

go 1.19 version upgrade

Signed-off-by: root <root@cineaste1.fyre.ibm.com>

fix merge issues

solved merge issues

Signed-off-by: jcho02 <jason.cho2@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants