Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates GH Actions to avoid using deprecated node #1117

Merged

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Jun 26, 2023

Description of the change:

Updates GH actions to versions which use Node 16.

Motivation for the change:

Currently some of our actions produce the following warning:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

NOTE: This PR doesn't update actions/checkout@ to v3 in .github/workflows/unit.yaml as it breaks .github/workflows/codecov.sh. See #1118 which switches this job to use codecov GH action and updates actions/checkout@ to v3.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 26, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2023
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #1117 (d5af84c) into master (6c60284) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head d5af84c differs from pull request most recent head 67a4faf. Consider uploading reports for the commit 67a4faf to get more accurate results

@@            Coverage Diff             @@
##           master    #1117      +/-   ##
==========================================
+ Coverage   52.64%   52.66%   +0.02%     
==========================================
  Files         108      108              
  Lines        9703     9703              
==========================================
+ Hits         5108     5110       +2     
+ Misses       3653     3651       -2     
  Partials      942      942              

see 1 file with indirect coverage changes

@m1kola m1kola marked this pull request as ready for review June 26, 2023 15:03
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, m1kola

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
@grokspawn
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023
@openshift-merge-robot openshift-merge-robot merged commit 337b60d into operator-framework:master Jun 26, 2023
10 checks passed
@m1kola m1kola deleted the gh_actions_warning branch June 27, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants