Switches to codecov GH action

[m1kola]

Description of the change:

Switches the repo to use codecov GH action.

Motivation for the change:

In #639 (after Codecov bash uploader vulnerability) this repo was switched to use copy-pasted bash script.

Since then many things changed:

• codecov/codecov-action no longer uses bash uploader
• This action validates sha sums

I think it is safe to switch back to this GH action.

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[m1kola]

I wanted to update it with rest of the actions in #1117, but .github/workflows/codecov.sh fails with v3. As far a s I understand, bash script relies on older version of node which was provided by actions/checkout@v2 and no longer works with Node 16.

[codecov]

Codecov Report

Merging #1118 (5c43e7b) into master (6c60284) will increase coverage by 1.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1118      +/-   ##
==========================================
+ Coverage   52.64%   53.80%   +1.15%     
==========================================
  Files         108      108              
  Lines        9703    10163     +460     
==========================================
+ Hits         5108     5468     +360     
- Misses       3653     3734      +81     
- Partials      942      961      +19     

see 63 files with indirect coverage changes

[m1kola]

Equivalent of -Z from the bash script.

[m1kola]

This is to avoid things like on the screenshot which decrease code coverage (bash uploader was doing it by default).

I believe this doc is related: https://docs.codecov.com/docs/fixing-reports#go

[m1kola]

Alternatively we can remove this line and estabilish a new baseline in master without enabling these fixes.

[grokspawn]

Honestly, good with either approach. Using 'fixes' right now seems generally good?

[m1kola]

Yeah, I think fixes gives exactly the same result as it was with the previous uploader. After adding fixes the diff between master coverage and this PR is empty (see results here).

[m1kola]

After adding fixes the diff between master coverage and this PR is empty (see results here).

Ah, interesting. Yesterday after running the tests the diff was empty and now it says +1.16%. Probably codecov was still processing when I opened the link.

Anyway - I think we should keep fixes for now.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, m1kola

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [grokspawn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[grokspawn]

/lgtm