Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph deprecation mermaid visualization update #1172

Conversation

rashmigottipati
Copy link
Member

Description of the change:
Add colorblind-friendly color indicators for deprecation of each scope (bundle, package and channel)

Motivation for the change:
Make it easy to visually identify the deprecated packages, bundles and channels from the mermaid graphs

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Closes 1160

Previous mermaid graph output without the color indications for deprecations of each scope:

original-mermaid-graph

With the changes in this PR, example mermaid graph output showcasing a deprecated channel kiali-alpha, bundle kiali-operator.v1.68.0, package kiali:

new-mermaid-graph

…e (bundle, channel, package)

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e23ef5) 53.67% compared to head (a2aced4) 53.77%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1172      +/-   ##
==========================================
+ Coverage   53.67%   53.77%   +0.10%     
==========================================
  Files         108      108              
  Lines       10340    10367      +27     
==========================================
+ Hits         5550     5575      +25     
- Misses       3808     3810       +2     
  Partials      982      982              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, everettraven, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit e5dca1a into operator-framework:master Dec 7, 2023
13 checks passed
}
}

var deprecatedPackage string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this PR is merged already, but the code here presumes that we will only ever have at most one deprecated package. If the scope of the declcfg includes multiple deprecated packages, does this work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graph deprecation mermaid visualization update
4 participants