(bugfix) Update to handle mermaid visualization for deprecation of multiple packages #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
grokspawn
approved these changes
Dec 12, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn, rashmigottipati The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
|
Closing this as this is not a bug and we're indeed handling the deprecation of multiple packages in this PR #1172 as operator-registry/alpha/declcfg/write.go Line 142 in e5dca1a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add colorblind-friendly color indicators for deprecation of each scope (bundle, package and channel) was merged last week. Based on this review comment, previously merged PR presumes that we will only ever have at most one deprecated package. This PR fixes that by handling the case of a declarative config includes multiple deprecated packages.