Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "controller-tools" Version Upgrade Instructions in the v1.25.0 Migration Guide #6525

Closed
tiwalter opened this issue Aug 1, 2023 · 0 comments · Fixed by #6526
Closed
Labels
kind/documentation Categorizes issue or PR as related to documentation.

Comments

@tiwalter
Copy link
Contributor

tiwalter commented Aug 1, 2023

The v.1.25.0 migration guide does not contain any instructions regarding the controller-tools version update to v0.10.0.

The version update was made here: https://github.com/operator-framework/operator-sdk/blame/v1.25.0/testdata/go/v3/memcached-operator/Makefile#L186 within this PR (#6047)

We need to add the follwing instruction:
In the Makefile file, replace CONTROLLER_TOOLS_VERSION ?= v0.9.2 with CONTROLLER_TOOLS_VERSION ?= v0.10.0

What is the URL of the document?

https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.25.0/

Which section(s) is the issue in?

https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.25.0/#kubebuilder-bump-brought-changes-that-modified-the-makefile-scaffolding-and-also-multiarch-changes-are-also-included

@tiwalter tiwalter added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 1, 2023
tiwalter added a commit to tiwalter/operator-sdk that referenced this issue Aug 1, 2023
tiwalter added a commit to tiwalter/operator-sdk that referenced this issue Aug 19, 2023
…ration guide (operator-framework#6525)

Signed-off-by: Timo Walter <twalter@walter-se.com>
tiwalter added a commit to tiwalter/operator-sdk that referenced this issue Aug 19, 2023
…ration guide (operator-framework#6525)

Signed-off-by: Timo Walter <twalter@walter-se.com>
tiwalter added a commit to tiwalter/operator-sdk that referenced this issue Aug 19, 2023
…ration guide (operator-framework#6525)

Signed-off-by: Timo Walter <twalter@walter-se.com>
@varshaprasad96 varshaprasad96 added this to the v1.32.0 milestone Aug 21, 2023
everettraven pushed a commit that referenced this issue Oct 5, 2023
…ration guide (#6525) (#6526)

Signed-off-by: Timo Walter <twalter@walter-se.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
2 participants