Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Go 1.19, Ginkgo v2 & kubebuilder 3.7.1 #6047

Merged

Conversation

laxmikantbpandhare
Copy link
Member

@laxmikantbpandhare laxmikantbpandhare commented Sep 29, 2022

Description of the change:
Changes in this PR are:

  • Modified go version to 1.19 in all the places and Kubebuilder to k8s 1.25
  • The config-gen is completely removed from Kubebuilder. As part of this bump, the website content of SDK was updated where the doc is referring to config-gen.
  • Updated ginkgo to ginkgo/v2 in all of the files. The reason behind it is that Kubebuilder updated to ginkgo/v2.
  • Updated all the io/ioutil imported packages to either io or os. io/ioutil got deprecated in 1.16 and no longer it is used. Updated all the files in SDK.
  • Ansible scaffolding got modified in order to incorporate with Kubebuilder --component-config flag changes. Previously, it was scaffolding and doing some file changes without considering the --component-config flag.
  • This PR bumped Kubebuilder to a newer version and it got the recent PR changes for the --component-config flag.
  • Helm scaffolding got modified in order to incorporate with Kubebuilder --component-config flag changes. Previously, it was scaffolding and doing some file changes without considering the --component-config flag.

Motivation for the change:

  • Ginkgo version mismatch in Kubebuilder and operator-sdk. ginkgo updated to ginkgo/v2
  • Updated io/ioutil to io or oc as io/ioutil got deprecated in 1.16
  • Updated go version to 1.19

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy September 29, 2022 19:52 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy September 29, 2022 19:52 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy September 29, 2022 19:52 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy September 29, 2022 19:52 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy September 29, 2022 19:52 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy September 29, 2022 19:52 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy September 29, 2022 19:52 Inactive
@laxmikantbpandhare laxmikantbpandhare self-assigned this Sep 29, 2022
@laxmikantbpandhare
Copy link
Member Author

Updated the Kubebuilder version as the new KB version has ginkgo/v2 changes.

@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy September 29, 2022 19:59 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy September 29, 2022 19:59 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy September 29, 2022 20:03 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy September 29, 2022 20:03 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy September 29, 2022 20:03 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy September 29, 2022 20:04 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy September 29, 2022 20:05 Inactive
@laxmikantbpandhare
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2022
@laxmikantbpandhare laxmikantbpandhare removed the request for review from fabianvf October 9, 2022 00:29
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy October 9, 2022 00:47 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy October 9, 2022 00:47 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy October 9, 2022 00:47 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy October 9, 2022 00:47 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy October 9, 2022 00:47 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy October 9, 2022 00:47 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy October 9, 2022 00:47 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy October 14, 2022 17:39 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy October 14, 2022 17:39 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy October 14, 2022 17:40 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy October 14, 2022 17:40 Inactive
@jmrodri
Copy link
Member

jmrodri commented Oct 14, 2022

/hold

I'm still reviewing the latest changes.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2022
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laxmikantbpandhare great work! Thanks for handling this big chunk of updates. Just a few changes in changeling fragments - It would be nice to include a snippet of git diff in migration sections, so that its easier for users to know what is getting added and/or deleted. Rest of the changes in SDK and plugins look good!

changelog/fragments/ansible-scaffolding-changes.yaml Outdated Show resolved Hide resolved
changelog/fragments/ansible-scaffolding-changes.yaml Outdated Show resolved Hide resolved
changelog/fragments/ansible-scaffolding-changes.yaml Outdated Show resolved Hide resolved
changelog/fragments/ansible-scaffolding-changes.yaml Outdated Show resolved Hide resolved
changelog/fragments/component-config-changes.yaml Outdated Show resolved Hide resolved
changelog/fragments/ginkgoV2-go-kb-bump-changes.yaml Outdated Show resolved Hide resolved
changelog/fragments/ginkgoV2-go-kb-bump-changes.yaml Outdated Show resolved Hide resolved
changelog/fragments/ginkgoV2-go-kb-bump-changes.yaml Outdated Show resolved Hide resolved
changelog/fragments/helm-scaffolding-changes.yaml Outdated Show resolved Hide resolved
internal/bindata/olm/manifests.go Show resolved Hide resolved
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog is meant to convey what things have changed that would affect a user's project. They don't care about changes we made to internal code.

How will go 1.19 update impact a users project? the io/ioutil is a good example.

How will ginkgo v2 affect them? They dont' care that we had to rename an internal variable like LabelsMap. They care that they might have to change their suite_test.go. So look at the difference of the testdata changes. THAT is usually what they care to see. So if the testdata changes the Makefile, what changed? That is what they will want to see.

Also, migrations are only important if it affects the scaffolded out project. If the change has no effect then no need for a migration.

I know it's not easy but you'll want to think about each of these as you write the changelogs. Usually the changelogs are easy because the changes in the PR aren't that big. But this is a HUGE PR and a lot changed :)

changelog/fragments/ansible-scaffolding-changes.yaml Outdated Show resolved Hide resolved
changelog/fragments/ansible-scaffolding-changes.yaml Outdated Show resolved Hide resolved
changelog/fragments/ansible-scaffolding-changes.yaml Outdated Show resolved Hide resolved
changelog/fragments/component-config-changes.yaml Outdated Show resolved Hide resolved
changelog/fragments/component-config-changes.yaml Outdated Show resolved Hide resolved
changelog/fragments/ginkgoV2-go-kb-bump-changes.yaml Outdated Show resolved Hide resolved
changelog/fragments/ginkgoV2-go-kb-bump-changes.yaml Outdated Show resolved Hide resolved
changelog/fragments/ginkgoV2-go-kb-bump-changes.yaml Outdated Show resolved Hide resolved
changelog/fragments/ginkgoV2-go-kb-bump-changes.yaml Outdated Show resolved Hide resolved
changelog/fragments/helm-scaffolding-changes.yaml Outdated Show resolved Hide resolved
@jmrodri
Copy link
Member

jmrodri commented Oct 14, 2022

/hold cancel

I finished my review

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2022
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy October 14, 2022 20:22 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy October 14, 2022 20:22 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy October 14, 2022 20:22 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy October 14, 2022 20:22 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy October 14, 2022 20:22 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy October 14, 2022 20:22 Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy October 14, 2022 20:22 Inactive
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. release-blocker This issue blocks the parent release milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New changes in kubebuilder causing issue in SDK testcases
7 participants