-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to Go 1.19, Ginkgo v2 & kubebuilder 3.7.1 #6047
Bump to Go 1.19, Ginkgo v2 & kubebuilder 3.7.1 #6047
Conversation
d3c1d26
to
31ad5bf
Compare
Updated the |
/hold |
/hold I'm still reviewing the latest changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@laxmikantbpandhare great work! Thanks for handling this big chunk of updates. Just a few changes in changeling fragments - It would be nice to include a snippet of git diff
in migration sections, so that its easier for users to know what is getting added and/or deleted. Rest of the changes in SDK and plugins look good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog is meant to convey what things have changed that would affect a user's project. They don't care about changes we made to internal code.
How will go 1.19 update impact a users project? the io/ioutil is a good example.
How will ginkgo v2 affect them? They dont' care that we had to rename an internal variable like LabelsMap. They care that they might have to change their suite_test.go. So look at the difference of the testdata changes. THAT is usually what they care to see. So if the testdata changes the Makefile, what changed? That is what they will want to see.
Also, migrations are only important if it affects the scaffolded out project. If the change has no effect then no need for a migration.
I know it's not easy but you'll want to think about each of these as you write the changelogs. Usually the changelogs are easy because the changes in the PR aren't that big. But this is a HUGE PR and a lot changed :)
/hold cancel I finished my review |
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description of the change:
Changes in this PR are:
config-gen
is completely removed from Kubebuilder. As part of this bump, the website content of SDK was updated where the doc is referring toconfig-gen
.io/ioutil
imported packages to eitherio
oros
.io/ioutil
got deprecated in 1.16 and no longer it is used. Updated all the files in SDK.--component-config
flag changes. Previously, it was scaffolding and doing some file changes without considering the--component-config
flag.--component-config
flag.--component-config
flag changes. Previously, it was scaffolding and doing some file changes without considering the--component-config
flag.Motivation for the change:
operator-sdk
.ginkgo
updated toginkgo/v2
io/ioutil
toio
oroc
asio/ioutil
got deprecated in1.16
1.19
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs