-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
up local command: add flag operator-flags #264
Conversation
kubernetes cluster using a kubeconfig file. | ||
`, | ||
Run: upLocalFunc, | ||
} | ||
|
||
upLocalCmd.Flags().StringVar(&kubeConfig, "kubeconfig", "", "The file path to kubernetes configuration file; defaults to $HOME/.kube/config") | ||
upLocalCmd.Flags().StringVar(&passThroughFlags, "extra-flags", "", "The extra flags that your operator will need. Example: \"--namespace test\"") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might want to make "extra-flags"
more explicit such as "operator-flags"
I think change the description to:
"The flags that the operator needs. Example: \"--flag1=value1 --flag2=value2 ...\""
sounds a bit more formal to avoid your
and will
.
|
||
return upLocalCmd | ||
} | ||
|
||
var ( | ||
kubeConfig string | ||
kubeConfig string | ||
passThroughFlags string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest to use operatorFlags
instead of passThroughFlags
.
lgtm |
One last nit, could you update the commit title to use operator-flags instead of extra-flags? |
extra-flags gives the ability to pass flags to the local operator. Fixes operator-framework#255
…-master Bug 2100001: Merge upstream tag v1.22.0
operator-flags gives the ability to pass flags to the local operator.
Fixes #255