Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/user-guide.md: add docs for cli cmd build #267

Merged
merged 1 commit into from
May 25, 2018

Conversation

srleyva
Copy link
Contributor

@srleyva srleyva commented May 18, 2018

started documentation for operator-sdk and added docs for build cmd

Refers #266

Is this a good place for the CLI documentation? @fanminshi

@srleyva srleyva force-pushed the cli-docs branch 4 times, most recently from 23e7ebb to 3f40016 Compare May 18, 2018 20:46

```

## up
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The up command was recently updated with more feature. could you update the this doc along with those?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the new features to the doc

@fanminshi
Copy link
Contributor

@srleyva sorry for the delay. I am waiting for a fix #274 and #264 before commenting on this doc.

The doc generally looks good.

@fanminshi
Copy link
Contributor

fanminshi commented May 25, 2018

@srleyva srleyva force-pushed the cli-docs branch 3 times, most recently from d396691 to 56f3be9 Compare May 25, 2018 18:43
@srleyva srleyva changed the title [WIP] doc/user-guide.md: add docs for cli cmd build doc/user-guide.md: add docs for cli cmd build May 25, 2018
##### Flags

* `-h, --help` - help for k8s

Copy link
Contributor

@etiennecoutaud etiennecoutaud May 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could add an Example section for k8s command to be consistent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it...also tried to keep the consistency in the generate olm-catalog doc as well.
Thanks for the suggestion!


* `-h, --help` - help for local

##### Example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let @shawn-hurley to provide additional descriptions on how to use those flags as he worked on this in a future PR.

```bash
operator-sdk build quay.io/example/operator:v0.0.1

// Output:
Copy link
Contributor

@fanminshi fanminshi May 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use

# Output:

Instead of

// Output:

Because I believe # is used for commenting in bash.

```bash
operator-sdk generate k8s

# Output
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed a :

```bash
operator-sdk generate olm-catalog --image=quay.io/example/operator:v0.0.1 --version=0.0.1

# Output
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed :

cd $GOPATH/src/github.com/example.com/
operator-sdk new app-operator --api-version=app.example.com/v1alpha1 --kind=AppService

//Output
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//Output -> # Output:?

//Output
Create app-operator/.gitignore
...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the extra line?

# Output
Run code-generation for custom resources
Generating deepcopy funcs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to have the extra line here.

@fanminshi
Copy link
Contributor

lgtm after nits.

added detailed docs for operator-sdk cli commands

Fixes operator-framework#266
@srleyva
Copy link
Contributor Author

srleyva commented May 25, 2018

Thanks for the help @fanminshi

Copy link
Contributor

@rithujohn191 rithujohn191 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fanminshi fanminshi merged commit cf1b5e0 into operator-framework:master May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants