Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using image digests instead of tags #5567

Merged
merged 4 commits into from
Feb 25, 2022

Conversation

ryantking
Copy link
Contributor

Description of the change:

Adds the ability to create operators that use image digests instead of tags for operator images as well as related images.

Motivation for the change:

https://github.com/operator-framework/enhancements/blob/master/enhancements/sha-bundle-digest.md

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@ryantking ryantking temporarily deployed to deploy February 23, 2022 22:00 Inactive
@ryantking ryantking temporarily deployed to deploy February 23, 2022 22:00 Inactive
@ryantking ryantking temporarily deployed to deploy February 23, 2022 22:00 Inactive
@ryantking ryantking temporarily deployed to deploy February 23, 2022 22:00 Inactive
@ryantking ryantking temporarily deployed to deploy February 23, 2022 22:00 Inactive
@ryantking ryantking temporarily deployed to deploy February 23, 2022 22:00 Inactive
@ryantking ryantking temporarily deployed to deploy February 23, 2022 22:00 Inactive
Ish Shah and others added 4 commits February 25, 2022 16:35
Signed-off-by: Ish Shah <ishah@redhat.com>
* add related images to bundle generation

Signed-off-by: Ryan King <ryking@redhat.com>

* regenerate and fix typos

Signed-off-by: Ryan King <ryking@redhat.com>

* no related images will be null, not an empty slice

Signed-off-by: Ryan King <ryking@redhat.com>

* regenerate to fix sanity

Signed-off-by: Ryan King <ryking@redhat.com>
Signed-off-by: Ryan King <ryking@redhat.com>
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
@jmrodri jmrodri temporarily deployed to deploy February 25, 2022 21:36 Inactive
@jmrodri jmrodri temporarily deployed to deploy February 25, 2022 21:36 Inactive
@jmrodri jmrodri temporarily deployed to deploy February 25, 2022 21:36 Inactive
@jmrodri jmrodri temporarily deployed to deploy February 25, 2022 21:36 Inactive
@jmrodri jmrodri temporarily deployed to deploy February 25, 2022 21:36 Inactive
@jmrodri jmrodri temporarily deployed to deploy February 25, 2022 21:36 Inactive
@jmrodri jmrodri temporarily deployed to deploy February 25, 2022 21:36 Inactive
@jmrodri
Copy link
Member

jmrodri commented Feb 25, 2022

@ryantking I forced an update to this branch so I could add the Signoff for Ish's initial commit which was causing DCO to fail. And I added the migration for camila.

Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2022
@theishshah theishshah merged commit 546e847 into master Feb 25, 2022
@theishshah theishshah deleted the feature/image-digests branch February 25, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants