-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use digest instead of tags in scorecard images #6393
Use digest instead of tags in scorecard images #6393
Conversation
The use of tags breaks disconnected environments when using mirrored images. Signed-off-by: Tony Garcia <tonyg@redhat.com>
Co-authored-by: Tatiana Krishtop <tkrishto@redhat.com> Signed-off-by: Tony Garcia <tonyg@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tonyskapunk for creating this PR! These changes look good to me!
/lgtm
Signed-off-by: Tony Garcia <tonyg@redhat.com>
New changes are detected. LGTM label has been removed. |
Thanks @everettraven I noticed the sanity test failed due to a pair of typos fixed in the last commit, whenever you have time I appreciate your review |
The docs sanity check is failing on an actually broken link but it will be fixed as part of #6394 Merging this |
* Use digest instead of tags in scorecard images The use of tags breaks disconnected environments when using mirrored images. Signed-off-by: Tony Garcia <tonyg@redhat.com> * Update internal/cmd/operator-sdk/scorecard/cmd.go Co-authored-by: Tatiana Krishtop <tkrishto@redhat.com> Signed-off-by: Tony Garcia <tonyg@redhat.com> * Fix typo in image Signed-off-by: Tony Garcia <tonyg@redhat.com> --------- Signed-off-by: Tony Garcia <tonyg@redhat.com> Co-authored-by: Tatiana Krishtop <tkrishto@redhat.com>
* Use digest instead of tags in scorecard images The use of tags breaks disconnected environments when using mirrored images. Signed-off-by: Tony Garcia <tonyg@redhat.com> * Update internal/cmd/operator-sdk/scorecard/cmd.go Co-authored-by: Tatiana Krishtop <tkrishto@redhat.com> Signed-off-by: Tony Garcia <tonyg@redhat.com> * Fix typo in image Signed-off-by: Tony Garcia <tonyg@redhat.com> --------- Signed-off-by: Tony Garcia <tonyg@redhat.com> Co-authored-by: Tatiana Krishtop <tkrishto@redhat.com> Signed-off-by: Catherine Chan-Tse <cchantse@redhat.com>
* Use digest instead of tags in scorecard images The use of tags breaks disconnected environments when using mirrored images. * Update internal/cmd/operator-sdk/scorecard/cmd.go * Fix typo in image --------- Signed-off-by: Tony Garcia <tonyg@redhat.com> Signed-off-by: Catherine Chan-Tse <cchantse@redhat.com> Co-authored-by: Tony Garcia <tonyskapunk@users.noreply.github.com> Co-authored-by: Tatiana Krishtop <tkrishto@redhat.com>
The use of tags breaks disconnected environments when using mirrored images.
Description of the change:
Reintroduces the use of Digest in the scorecard images instead of tags.
Motivation for the change:
Bring back default support to disconnected environments using scorecard.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
website/content/en/docs
Fixes: #6392