Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.28.x] Use digest instead of tags in scorecard images (#6393) #6410

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

oceanc80
Copy link
Collaborator

Cherry-pick of #6393

* Use digest instead of tags in scorecard images

The use of tags breaks disconnected environments when using mirrored
images.

Signed-off-by: Tony Garcia <tonyg@redhat.com>

* Update internal/cmd/operator-sdk/scorecard/cmd.go

Co-authored-by: Tatiana Krishtop <tkrishto@redhat.com>
Signed-off-by: Tony Garcia <tonyg@redhat.com>

* Fix typo in image

Signed-off-by: Tony Garcia <tonyg@redhat.com>

---------

Signed-off-by: Tony Garcia <tonyg@redhat.com>
Co-authored-by: Tatiana Krishtop <tkrishto@redhat.com>
Signed-off-by: Catherine Chan-Tse <cchantse@redhat.com>
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2023
@oceanc80 oceanc80 merged commit 3e03bbb into operator-framework:v1.28.x Apr 28, 2023
@oceanc80 oceanc80 deleted the v1.28.x branch April 28, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants