Refactor wallet module #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove details from fiActions in wallet and accountant * Use enum for withdraw status * Use enum for more hardcoded variables * Use enum for transfer category * Modify database * Add try catch in wallet BackupService * FinancialActionJobKafka TBC * Adding rest services * Add admin tx for DEPOSIT_MANUALLY * Remove balance_before * Change fi_actions transfer ref to use uuid * Fix test failure * Fix type mismatch error * Make one test function suspended * Fix quote asset not included in estimated value * Edit schema Transaction refactor completed
* Start refactoring withdraw * Remove applied_fee Refactor withdraw service * Delete deprecated services * Add fee service * Fix amount mismatch * Fix user transaction service
* Simplified deposit services * Clean up withdraw services
fatemeh-i
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.