Feature/work package on page diff #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functionality itself is adapted from issue#show. On the other hand, the diff is no longer rendered with the full url as the link's href. Using the full url caused problems with selenium tests that ran into problems with cross domain requests. This could have been fixed by setting the application's host and protocol setting accordingly. However, it is much cleaner to use a relative url. So for rendering the diff inside the application the behaviour was alterd to use relative url. The full url is now only used where it is absolutely necessary (pdf, email).
This view should not be specific to issues/work_packages. Using polymorphic_url will for now lead to paths like "/issues/5". But once only work_packages exist this will no longer be a problem.
nkenneweg
added a commit
that referenced
this pull request
Jul 18, 2013
Feature/work package on page diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality itself is adapted from issue#show.
On the other hand, the diff is no longer rendered with the full url as the
link's href. Using the full url caused problems with selenium tests that
ran into problems with cross domain requests. This could have been fixed
by setting the application's host and protocol setting accordingly.
However, it is much cleaner to use a relative url. So for rendering the
diff inside the application the behaviour was alterd to use relative
url. The full url is now only used where it is absolutely necessary
(pdf, email).
Issue on OP: https://www.openproject.org/issues/1420