Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/work package on page diff #255

Merged
merged 3 commits into from
Jul 18, 2013
Merged

Feature/work package on page diff #255

merged 3 commits into from
Jul 18, 2013

Commits on Jul 18, 2013

  1. introduces ajax triggered inline diff on work_package#show 

    The functionality itself is adapted from issue#show.

On the other hand, the diff is no longer rendered with the full url as the
link's href. Using the full url caused problems with selenium tests that
ran into problems with cross domain requests. This could have been fixed
by setting the application's host and protocol setting accordingly.
However, it is much cleaner to use a relative url. So for rendering the
diff inside the application the behaviour was alterd to use relative
url. The full url is now only used where it is absolutely necessary
(pdf, email).
    @ulferts @nkenneweg
    ulferts authored and nkenneweg committed Jul 18, 2013
    Configuration menu
    Copy the full SHA
    bacb3f0 View commit details
    Browse the repository at this point in the history

  2. more general implementation for diff view 

    This view should not be specific to issues/work_packages.

Using polymorphic_url will for now lead to paths like "/issues/5".
But once only work_packages exist this will no longer be a problem.
    @ulferts @nkenneweg
    ulferts authored and nkenneweg committed Jul 18, 2013
    Configuration menu
    Copy the full SHA
    05de02a View commit details
    Browse the repository at this point in the history

  3. updates changelog

    @ulferts @nkenneweg
    ulferts authored and nkenneweg committed Jul 18, 2013
    Configuration menu
    Copy the full SHA
    45a4af6 View commit details
    Browse the repository at this point in the history