Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): target api update #432

Merged
merged 4 commits into from
Oct 3, 2023
Merged

feat(frontend): target api update #432

merged 4 commits into from
Oct 3, 2023

Conversation

artek-koltun
Copy link
Contributor

@artek-koltun
chore(deps): udpate opi-spdk-bridge to 3e4c52f
5166d86 
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun
refactor(frontend): target api update
24f5b1d 
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun artek-koltun changed the title feat(frontend): target api support feat(frontend): target api update Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023 •
edited
Loading

Codecov Report

Merging #432 (dbbb52a) into main (de671c2) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
+ Coverage   89.25%   89.40%   +0.15%     
==========================================
  Files           7        7              
  Lines         828      840      +12     
==========================================
+ Hits          739      751      +12     
  Misses         63       63              
  Partials       26       26
Files Coverage Δ
pkg/frontend/nvme_controller.go 91.15% <100.00%> (ø)
pkg/frontend/nvme_controller_validate.go 86.95% <100.00%> (+4.60%) ⬆️

@artek-koltun
feat(frontend): check controller transport type
5b55b02 
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
artek-koltun
artek-koltun commented Oct 3, 2023
View reviewed changes
Copy link
Contributor Author

@artek-koltun artek-koltun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sburla-marvell could you please point out what api you use in Marvell to create NVMe-oF controllers?

@artek-koltun artek-koltun marked this pull request as ready for review October 3, 2023 08:15
@artek-koltun artek-koltun requested a review from a team as a code owner October 3, 2023 08:15
glimchb
glimchb reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update readme as well?

@artek-koltun
docs: update CreateNvmeController cmd
dbbb52a 
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
glimchb
glimchb approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtrm

@glimchb glimchb merged commit 29ae598 into opiproject:main Oct 3, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glimchb glimchb glimchb approved these changes

@sburla-marvell sburla-marvell Awaiting requested review from sburla-marvell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artek-koltun @glimchb