feat(storage): frontend traget case API #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
artek-koltun
commented
Sep 27, 2023
artek-koltun
requested review from
a team,
glimchb,
benlwalker,
jainvipin,
sburla-marvell and
GottliebNoam
intelfisz
approved these changes
Sep 28, 2023
sburla-marvell
approved these changes
Sep 28, 2023
glimchb
approved these changes
Sep 28, 2023
artek-koltun
force-pushed
the
feat-frontend-traget-case
branch
from
9199a43 to
6869961
Compare
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
|
@sanders-mark please hold this merge until Monday @artek-koltun will merge himself when ready |
glimchb
reviewed
Sep 29, 2023
| @@ -43,6 +43,18 @@ message PciEndpoint { | |||
| google.protobuf.Int32Value virtual_function = 3 [(google.api.field_behavior) = REQUIRED]; | |||
| } | |||
|
|
|||
| // Represents Fabrics Endpoint | |||
| message FabricsEndpoint { | |||
There was a problem hiding this comment.
nvme: consider combining FabricsEndpoint and FabricsPath
since we want to extend this message with more fields anyways
This was referenced Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.