Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): target api update #428

Merged

Conversation

artek-koltun
Copy link
Contributor

@artek-koltun artek-koltun commented Oct 3, 2023

see opiproject/opi-api#375

@benlwalker @GottliebNoam Could you please clarify what api you use to create NVMe-oF controllers in Nvidia xPUs

Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #428 (5db6f16) into main (8eeab14) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
+ Coverage   90.99%   91.05%   +0.06%     
==========================================
  Files           9        9              
  Lines         877      883       +6     
==========================================
+ Hits          798      804       +6     
  Misses         56       56              
  Partials       23       23              
Files Coverage Δ
pkg/frontend/nvme_controller.go 93.64% <100.00%> (ø)
pkg/frontend/nvme_controller_validate.go 85.00% <100.00%> (+2.64%) ⬆️

@artek-koltun artek-koltun marked this pull request as ready for review October 3, 2023 09:25
@artek-koltun artek-koltun requested a review from a team as a code owner October 3, 2023 09:25
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update readme

Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@glimchb
Copy link
Member

glimchb commented Oct 3, 2023

@benlwalker @GottliebNoam Could you please clarify what api you use to create NVMe-oF controllers in Nvidia xPUs

@artek-koltun see documentation https://docs.nvidia.com/networking/display/bluefield3snaplatest/SNAP+RPC+Commands

Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@glimchb glimchb merged commit 4b57f4a into opiproject:main Oct 3, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants