Fix v1.9.0 bug #31
Merged
Fix v1.9.0 bug #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reverted the code bricking the score calculation * Removed obsolete activeSceneChanged unsubscribe
|
Once again, thank you for the PR. I'll try to release it as soon as I can. I would recommend that in the future you describe what the fix actually fixes in the commit message and the PR name instead of what version it applies to, since that information is more useful. I would also recommend you try to learn how to work with branches and at some point also how to rebase your changes, both of which should make your git history cleaner and help limit the commits listed in PRs you make. |
|
Thank you, and again sorry about everything 🙇 |
|
For future reference, the explanation of what this PR does is in the previous PR: https://github.com/opl-/beatsaber-http-status/pull/30#issuecomment-570259532 Will publish this in a bit. |
opl-
added a commit
that referenced
this pull request
Jan 3, 2020
Fixes: - Rank and note events not processed correctly (#31)
rynan4818
pushed a commit
to rynan4818/beatsaber-http-status-db
that referenced
this pull request
Sep 14, 2024
30 lighting event bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rank and notes were not being processed correctly due to OnActiveSceneChange being called two times