Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic size is not correctly computed #1348

Closed
BenHenning opened this issue Jun 18, 2020 · 0 comments · Fixed by #1352
Closed

Topic size is not correctly computed #1348

BenHenning opened this issue Jun 18, 2020 · 0 comments · Fixed by #1352
Assignees
@rt4914
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.4 Release Block...

Comments

@BenHenning
Copy link
Member

BenHenning commented Jun 18, 2020 •
edited
Loading

The topic download size is always 0 bytes, presumably because we are setting the ObservableField topic value after we compute the size in TopicInfoViewModel.

Screenshot example:
image
@BenHenning BenHenning self-assigned this Jun 18, 2020
@BenHenning BenHenning added Priority: Essential This work item must be completed for its milestone. Status: Not started labels Jun 18, 2020
@BenHenning BenHenning added this to the Alpha milestone Jun 18, 2020
@BenHenning BenHenning assigned rt4914 and unassigned BenHenning Jun 18, 2020
@rt4914 rt4914 mentioned this issue Jun 18, 2020
Merged
8 tasks
rt4914 added a commit that referenced this issue Jun 18, 2020
@rt4914
Fix #1348: Topic Size issue fixed (#1352)
1e70613 
* Fixed topic download size issue

* Reformatted code

Co-authored-by: Rajat Talesra <talesra@google.com>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.4 Release Blockers (Alpha MR1)
Development

Successfully merging a pull request may close this issue.

Fix #1348: Topic Size issue fixed oppia/oppia-android
2 participants
@rt4914 @BenHenning