Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1348: Topic Size issue fixed #1352

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Fix #1348: Topic Size issue fixed #1352

merged 2 commits into from
Jun 18, 2020

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Jun 18, 2020

Explanation

Fixes #1348

Currently in develop, TopicInfoFragment displays 0 Bytes as topic size. This is fixed in this PR.
Note that the topic size can be calculated only for those topics which are coming from json files and therefore First Topic and Second Topic will still show topic size as 0 bytes.

Screenshot_1592444820

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Jun 18, 2020
@rt4914 rt4914 merged commit 1e70613 into develop Jun 18, 2020
@rt4914 rt4914 deleted the topic-download-size-fix branch June 18, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topic size is not correctly computed
2 participants