Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create text based styles in styles.xml #1914

Closed
rt4914 opened this issue Sep 29, 2020 · 3 comments · Fixed by #1915
Closed

Create text based styles in styles.xml #1914

rt4914 opened this issue Sep 29, 2020 · 3 comments · Fixed by #1915
Assignees
@rt4914
Labels
Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Sep 29, 2020

The current UI contains a lot of common views and therefore we should define those common styles in styles.xml file.
The styles should be defined for following items as a start and can be added more as we start updating the UI.

Screenshot 2020-09-29 at 11 15 23 AM
@rt4914 rt4914 self-assigned this Sep 29, 2020
@rt4914 rt4914 added Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Status: In implementation labels Sep 29, 2020
@rt4914 rt4914 added this to the Backlog milestone Sep 29, 2020
@Arjupta
Copy link
Contributor

Arjupta commented Sep 29, 2020

@rt4914 sir can I work on this issue? I will need some help though.

@rt4914
Copy link
Contributor Author

rt4914 commented Sep 29, 2020

@rt4914 sir can I work on this issue? I will need some help though.

@Arjupta Have a look at the Assignees section, if there is a person mentioned that means its already assigned. In this case it is assigned to me.
You can pick any issues from this link: https://github.com/oppia/oppia-android/issues?q=is%3Aopen+is%3Aissue+no%3Aassignee+label%3A%22good+first+issue%22

@Arjupta
Copy link
Contributor

Arjupta commented Sep 29, 2020

@rt4914 sir can I work on this issue? I will need some help though.

@Arjupta Have a look at the Assignees section, if there is a person mentioned that means its already assigned. In this case it is assigned to me.
You can pick any issues from this link: https://github.com/oppia/oppia-android/issues?q=is%3Aopen+is%3Aissue+no%3Aassignee+label%3A%22good+first+issue%22

Ok got it

@rt4914 rt4914 mentioned this issue Sep 30, 2020
Merged
8 tasks
rt4914 added a commit that referenced this issue Sep 30, 2020
@rt4914
Fix #1914: Added text based styles (#1915)
a447910 
* Added text based styles

* Nit fix

* Optimised code

* Common UI code

* Fixed comment issue

* Renamed headings

Co-authored-by: Rajat Talesra <talesra@google.com>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1914: Added text based styles oppia/oppia-android
3 participants
@rt4914 @BenHenning @Arjupta