Fix #1914: Added text based styles #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 29, 2020 11:14
rt4914
requested review from
anandwana001,
MohamedMedhat1998 and
Sarthak2601
|
@anandwana001 @MohamedMedhat1998 @Sarthak2601 Please have a look at the description and code. This is important as you will also be reviewing PRs related to UI changes and these things will get used more often now. |
anandwana001
approved these changes
Sep 29, 2020
aggarwalpulkit596
suggested changes
Sep 29, 2020
aggarwalpulkit596
approved these changes
Sep 29, 2020
Sarthak2601
approved these changes
Sep 29, 2020
|
@aggarwalpulkit596 Can you please resolve comments if both queries are answered? |
|
Merging this now but @MohamedMedhat1998 feel free to have a look and leave comment. |
Comment on lines
+235
to
+239
| <style name="Caption" parent="TextView.Common1"> | ||
| <item name="android:fontFamily">sans-serif-medium</item> | ||
| <item name="android:textSize">14sp</item> | ||
| <item name="fontFamily">sans-serif-medium</item> | ||
| </style> |
There was a problem hiding this comment.
According to #1914 description, this should be sans-serif not sans-serif-medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fix #1914
The current UI contains a lot of common views and therefore we should define those common styles in
styles.xmlfile.The styles should be defined for following items as a start and can be added more as we start updating the UI.
Note: I have not added style for
BUTTONbecause we already haveStateButtonActive.Also, these are just the starter styles, as we move to the UI part we should focus on creating common styles which can be used at multiple places.
Checklist