Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lowfi: HelpActivity (Part 1) #692

Closed
rt4914 opened this issue Feb 22, 2020 · 10 comments · Fixed by #724
Closed

Lowfi: HelpActivity (Part 1) #692

rt4914 opened this issue Feb 22, 2020 · 10 comments · Fixed by #724
Assignees
@SayantanBanerjee16
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.4 Release Block...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Feb 22, 2020

Mock: https://xd.adobe.com/view/0687f00c-695b-437a-79a6-688e7f4f7552-70b6/screen/8e1bbf3c-3287-4149-b599-5d5a5486809d/HL-Help-Menu-

In this we don't need to include Send. Feedback feature.

Also, create an empty FAQActivity with its fragment and presenter in this PR and write test cases too.
@rt4914 rt4914 changed the title Lowfi: HelpActivity Lowfi: HelpActivity (Part 1) Feb 22, 2020
@rt4914 rt4914 added Priority: Essential This work item must be completed for its milestone. Workstream: Lowfi UI labels Feb 22, 2020
@PrarabdhGarg
Copy link
Contributor

@rt4914 in this should I add a recycler view, considering extra option might be added in the future? Or should I just add a single text view for now?

@rt4914
Copy link
Contributor Author

rt4914 commented Feb 22, 2020

@rt4914 in this should I add a recycler view, considering extra option might be added in the future? Or should I just add a single text view for now?

Yes.

@rt4914
Copy link
Contributor Author

rt4914 commented Feb 22, 2020

@rt4914 in this should I add a recycler view, considering extra option might be added in the future? Or should I just add a single text view for now?

Actually considering that you have not worked on recyclerview yet in this Project and you already have one task assigned regarding the recyclerview, lets unassign you from this because you have very less time to work on right now.

@PrarabdhGarg
Copy link
Contributor

@rt4914 sure. No problem

@aggarwalpulkit596
Copy link
Contributor

@rt4914 can I take this one?

@rt4914
Copy link
Contributor Author

rt4914 commented Feb 24, 2020

@rt4914 can I take this one?

Hello @aggarwalpulkit596 before we get started on any task, please go through this https://github.com/oppia/oppia-android/wiki and also, make sure that you sign the CLA and fill the survey form. Once that is done, we will assign you some issues to get started.

@aggarwalpulkit596
Copy link
Contributor

okay 👍

@aggarwalpulkit596
Copy link
Contributor

@rt4914 Hey, I've already completed the survey as well as signed the CLA. Can you take a look at it so that I can start contributing

@rt4914
Copy link
Contributor Author

rt4914 commented Feb 26, 2020

Assigning this to @SayantanBanerjee16 now.

@SayantanBanerjee16
Copy link
Contributor

Assigning this to @SayantanBanerjee16 now.

Okay sir, am on it.

@SayantanBanerjee16 SayantanBanerjee16 self-assigned this Feb 27, 2020
@SayantanBanerjee16 SayantanBanerjee16 mentioned this issue Feb 28, 2020
Merged
8 tasks
rt4914 pushed a commit that referenced this issue Mar 7, 2020
@SayantanBanerjee16
Fix #692: Lowfi: HelpActivity (Part 1) (#724)
0e319b3 
* Single item layout done

* Recycler view implemented using MVVM

* Refractoring done and minor fix

* FAQ fragment, activity and its presenter created

* Interface created

* Help FAQ test implemented

* Refractoring done

* Item click implemented

* Test bug fixed

* Refractoring done

* Nit changes and refractor

* Refractor in fetching ViewModel

* Tests modified

* HelpItems enum class implemented

* Refractoring and NIT changes

* Interface and OnClick listener done

* NIT changes

* refractoring done and bug fix

* Indentation fixed

* RouteToFAQ interface implemented

* Item click done through enum of HelpItem

* Constructor redefined in HelpViewModel

* Undoing addition of auto-generated lines

* Manifest files re-arrangement

* Nit changes

* Nit changes and refactoring

* Item click done inside Adapter and corresponding View Model itemClick deleted

* Comment modified

* Secondary constructor omitted in HelpViewModel

* Indentation fix

* HelpActivity Test added and NIT fix

* NIT fix
@BenHenning BenHenning added this to the Alpha milestone Jun 23, 2020
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SayantanBanerjee16 SayantanBanerjee16

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.4 Release Blockers (Alpha MR1)
Development

Successfully merging a pull request may close this issue.

Fix #692: Lowfi: HelpActivity (Part 1)
5 participants
@rt4914 @BenHenning @aggarwalpulkit596 @PrarabdhGarg @SayantanBanerjee16