Fix #692: Lowfi: HelpActivity (Part 1)

[SayantanBanerjee16]

Explanation

Fixes #692:
The recycler view has been implemented through MVVM and its working fine, FAQ activity, fragment & their presenters are implemented and also tests have been written.

Checklist

• The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
• The PR follows the style guide.
• The PR does not contain any unnecessary auto-generated code from Android Studio.
• The PR is made from a branch that's not called "develop".
• The PR is made from a branch that is up-to-date with "develop".
• The PR's branch is based on "develop" and not on any other branch.
• The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

[rt4914]

I have just taken an overview look now. You will mainly need to change the implementation of Recyclerview.

[SayantanBanerjee16]

Thanks for the review. I will do the changes accordingly.

[SayantanBanerjee16]

@rt4914 Done with all the changes you had suggested. Also Recycler View is working fine along with clicking on the FAQ item, FAQ activity is launched. Also, the relevant Test implemented.

Please review. Thanks :)

[rt4914]

I have mentioned some implementation change to layout options in HelpActivity. PTAL

[rt4914]

I have suggested changes. In short to improvise on your PR quality you can following following steps:

1. Once your PR is ready, go to Files Changed.
2. Check if there are any unnecessary files changes which you have not introduced but are still showing because of android studio, then revert those changes.
3. Now go through each file in Files Changed and open that same file in Android Studio and do following steps:

• Control + Alt + L - formatting shortcut.
• Try to solve all possible warnings given by android studio.

4. Once all these changes are done, run the test cases which you have written in this PR, if any.

Once all this is done, commit again if there are any changes and then assign it to the reviewers.

[SayantanBanerjee16]

@rt4914 OnCLick has been handled in Adapter instead of View Model and also every other NIT fixed, indentation fix is done, and removed any unused lines, calls, and imports. Please review :)

[rt4914]

This looks like a very nice implementation. Just some final changes suggested. Thanks.

[rt4914]

LGTM, there are some nit changes PTAL.

Also, I think after these nit changes we can merge this PR.

[rt4914]

@SayantanBanerjee16 There is one suggestion, do not mark conversations Resolve conversation directly, instead, reply to the conversation, something like Done and when I review it again, I will mark it as resolve that way its easier to review PRs.

[SayantanBanerjee16]

@SayantanBanerjee16 There is one suggestion, do not mark conversations Resolve conversation directly, instead, reply to the conversation, something like Done and when I review it again, I will mark it as resolve that way its easier to review PRs.

Okay, will follow this from next time.

[SayantanBanerjee16]

@rt4914 Done the NIT changes. Please merge if it's good to go. Thanks :)