Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lowfi Landscape: ProfileList #726

Closed
rt4914 opened this issue Feb 28, 2020 · 3 comments · Fixed by #843
Closed

Lowfi Landscape: ProfileList #726

rt4914 opened this issue Feb 28, 2020 · 3 comments · Fixed by #843
Assignees
@rt4914
Labels
good first issue This item is good for new contributors to make their pull request. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.4 Release Block...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Feb 28, 2020

Mock:
https://xd.adobe.com/view/ee9e607b-dbd6-4372-48dc-b687d32af3da-98af/screen/0a5af83d-4b03-4a71-bf01-0c0a6e97e0c2/RG-MN-Register-Empty-34/

Currently app supports only portrait mode for ProfileListActivity, so add landscape mode too.
Add test cases for landscape mode too.
@rt4914 rt4914 added Worksteam: Landscape good first issue This item is good for new contributors to make their pull request. labels Feb 28, 2020
@rt4914
Copy link
Contributor Author

rt4914 commented Feb 28, 2020

Assigning this to @Czeach

@rt4914 rt4914 self-assigned this Feb 28, 2020
@rounaakk rounaakk mentioned this issue Mar 7, 2020
Closed
8 tasks
@rt4914
Copy link
Contributor Author

rt4914 commented Mar 10, 2020

@rounak122 Thanks for showing interest in Oppia. But one important thing, if an issue has already been assigned to someone else that means that you cannot work on that because the Assigned person will be working on that. So please keep note of this thing.

For this PR it is fine considering that @Czeach is not working on this PR.

@rt4914
Copy link
Contributor Author

rt4914 commented Mar 10, 2020 •
edited
Loading

Unassigned to @rounak122

@rt4914 rt4914 assigned Sarthak2601 and unassigned rt4914 Mar 18, 2020
@rt4914 rt4914 mentioned this issue Mar 19, 2020
Closed
8 tasks
@Sarthak2601 Sarthak2601 mentioned this issue Mar 19, 2020
Closed
8 tasks
@rt4914 rt4914 assigned rt4914 and unassigned Sarthak2601 Mar 20, 2020
@rt4914 rt4914 mentioned this issue Mar 20, 2020
Merged
8 tasks
rt4914 added a commit that referenced this issue Mar 21, 2020
@rt4914
Fix #726: Landscape profile list (#843)
bfd7c0a 
* Landscape mode

* Test cases

* Merge conflicts resolved

Co-authored-by: Rajat Talesra <talesra@talesra-macbookpro.roam.corp.google.com>
@BenHenning BenHenning added this to the Alpha milestone Jun 23, 2020
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
good first issue This item is good for new contributors to make their pull request. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.4 Release Blockers (Alpha MR1)
3 participants
@rt4914 @BenHenning @Sarthak2601