Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #726: Landscape profile list #843

Merged
merged 5 commits into from
Mar 21, 2020
Merged

Fix #726: Landscape profile list #843

merged 5 commits into from
Mar 21, 2020

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Mar 20, 2020

Explanation

Fixes #726

Mock: https://xd.adobe.com/view/ee9e607b-dbd6-4372-48dc-b687d32af3da-98af/screen/0a5af83d-4b03-4a71-bf01-0c0a6e97e0c2/RG-MN-Register-Empty-34/

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 requested a review from Luffy18346 March 20, 2020 15:51
@rt4914 rt4914 assigned Luffy18346 and unassigned Luffy18346 Mar 20, 2020
Copy link
Contributor

@Luffy18346 Luffy18346 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks.

@rt4914 rt4914 merged commit bfd7c0a into develop Mar 21, 2020
@Luffy18346 Luffy18346 assigned rt4914 and unassigned Luffy18346 Mar 21, 2020
@rt4914 rt4914 deleted the landscape-profile-list branch June 24, 2020 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lowfi Landscape: ProfileList
2 participants