-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lowfi: WalkthrougTopicListFragment Part 2 #812
Comments
@rt4914 Can you please explain this workflow how to display the list what action to do perform on user selection etc |
Actually this implementation resembles the implementation of |
@rt4914 should I make a separate adapter for this or should reuse the existing code because TopicListViewHolder will be exactly same as before |
@rt4914 also how do I have to handle the selection of a topic because in this PR I have to make things in order to fulfill the needs of the last walkthrough fragment |
There are two approaches to this:
I would suggest you to apply step 2 instead of 1, as learning about The above description is for Adapter/data only. Second part of this implementation is how data is arranged because the index0 item is the text and other items are a grid layout manager. So it looks like it is a combination of LinearLayoutManager and GridLayoutManager. So for this you can take help from
|
@rt4914 actually I was using the second approach and already gone through all these files /codes |
@aggarwalpulkit596 Okay, so where you are exactly stuck right now? |
Nowhere just trying to implement without taking multiple reviews this time😅 |
Great to know that. :-) |
@rt4914 should I make a separate file for topic_summary view as well? |
* Add Header in WalkthroughTopicListFragment * Add WalkthroughTopicSummaryViewModel * Show Topic List in RecyclerView * Handle topic item click * handling topicId in WalkthroughFinalFragment * Add WalkthroughTopicListFragment test * nit changes * undo refractor change * nit changes
Mock: https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/92becc49-3a10-498b-885c-4cde95f73d51/WT-Topic-List-
WalkthroughTopicListFragment implementation should match as per mocks.
The text was updated successfully, but these errors were encountered: