Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1584 : Change font size to multiplier factor #1751

Merged
merged 24 commits into from
Sep 3, 2020
Merged

Fix #1584 : Change font size to multiplier factor #1751

merged 24 commits into from
Sep 3, 2020

Conversation

prayutsu
Copy link
Contributor

Explanation

Fixes #1584
Changed the hard-coded font size to the multiplier factor

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

prayutsu and others added 20 commits August 21, 2020 22:09
@prayutsu
Merge pull request #2 from oppia/develop
b0eb1da 
update fork approved
@prayutsu
Merge remote-tracking branch 'upstream/develop' into develop
038bd14 
update local copy
@prayutsu
Merge pull request #3 from oppia/develop
620c534 
update fork approved
@prayutsu
Merge pull request #6 from oppia/develop
4195b6a 
update develop
@prayutsu
Merge remote-tracking branch 'upstream/develop' into develop
92bc7ab 
update develop
@prayutsu
Merge branch 'develop' of https://github.com/prayutsu/oppia-android i…
81f13e9 
…nto develop

update
@prayutsu
Merge pull request #13 from oppia/develop
f06d1be 
update my develop
@prayutsu
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
4ab3ef4 
… develop

update fork
@prayutsu
Merge remote-tracking branch 'origin/develop' into develop
0b02af9
@prayutsu
Merge pull request #14 from oppia/develop
1affc4e 
update fork
@prayutsu
check fork
da6256c
@prayutsu
Merge remote-tracking branch 'origin/develop' into develop
93f9a17
@prayutsu
local develop branch synced with remote branch
398b582
@prayutsu
Merge remote-tracking branch 'upstream/develop' into develop
ae9014b
@prayutsu
Merge remote-tracking branch 'upstream/develop' into develop
c08e66c
@prayutsu
Merge remote-tracking branch 'upstream/develop' into develop
d347418
@prayutsu
Merge remote-tracking branch 'upstream/develop' into develop
ef916a2
@prayutsu
Changed text size to multiplier factor
f448470
@prayutsu
Merge remote-tracking branch 'upstream/develop' into change-font-size…
0c4b442 
…-to-multiplier-factor
@prayutsu
fixed errors
d591997
@prayutsu prayutsu requested a review from rt4914 August 31, 2020 09:47
@prayutsu
Copy link
Contributor Author

@rt4914 PTAL

rt4914
rt4914 suggested changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some nit changes.

app/src/main/java/org/oppia/app/options/ReadingTextSizeFragmentPresenter.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/app/options/ReadingTextSizeFragmentPresenter.kt Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned prayutsu and unassigned rt4914 Sep 1, 2020
@prayutsu
Copy link
Contributor Author

prayutsu commented Sep 2, 2020

@rt4914 PTAL

@prayutsu prayutsu removed their assignment Sep 2, 2020
@rt4914 rt4914 assigned prayutsu and unassigned rt4914 Sep 2, 2020
@prayutsu
Copy link
Contributor Author

prayutsu commented Sep 2, 2020

@rt4914 PTAL

@prayutsu prayutsu assigned rt4914 and unassigned prayutsu Sep 2, 2020
rt4914
rt4914 suggested changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit suggestion else everything is great. Thanks.

app/src/main/java/org/oppia/app/options/ReadingTextSizeFragmentPresenter.kt Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned prayutsu and unassigned rt4914 Sep 3, 2020
@prayutsu prayutsu assigned rt4914 and unassigned prayutsu Sep 3, 2020
@prayutsu
Copy link
Contributor Author

prayutsu commented Sep 3, 2020

@rt4914 PTAL, All the requested changes are done!

rt4914
rt4914 approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit cf22b93 into oppia:develop Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In StoryTextSize Options change font size to multiplier factor
2 participants
@prayutsu @rt4914