Fix #935: Optimised test cases for HDPI devices #942

NullByte08 · 2020-04-03T22:18:15Z

Explanation

Fix #935

All the test cases except for player package now run and pass successfully on HDPI devices too as required by the issue. I used the Nexus S emulator.

Checklist

The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
The PR follows the style guide.
The PR does not contain any unnecessary auto-generated code from Android Studio.
The PR is made from a branch that's not called "develop".
The PR is made from a branch that is up-to-date with "develop".
The PR's branch is based on "develop" and not on any other branch.
The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

updating

update

app/src/sharedTest/java/org/oppia/app/settings/profile/ProfileEditActivityTest.kt

app/src/sharedTest/java/org/oppia/app/topic/revision/TopicRevisionFragmentTest.kt

NullByte08 · 2020-04-07T00:17:27Z

@rt4914 I have just added the comments so as to bring them to your attention. Otherwise, all the test are completely compatible now with HDPI devices.

rt4914 · 2020-04-07T05:57:01Z

@NullByte08 I ran all test cases at once. And here are some details regarding to that.

AdminstratorControlsActivityTest -> Tests are failing because the UI is not visible on screen. Mainly you will need to add scrollTo functionality in the failing test cases.
player package test cases you can avoid.
TopicRevisionFragmentTest -> These test cases will need to be updated. For reference you can see HomeActivityTest in which we are checking span count in similar way. Try to use this information to fix the test cases if it does not workout, do inform me and I can give you more hints.
ProfileEditActivityTest -> For this the functionality in code is incorrect and the test case has been written in the correct way.
Follow these steps:

ProfileChooser Screen -> Administrator Controls -> Enter Pin
Click on Edit Profiles
Click on Sean's profile
Now in toolbar you will notice that the name is Sean now do orientation change in mobile and you will see that toolbar shows Oppia.
You should fix this functionality to fix the test case itself.

This issue is sort of a mini project as it was known that it will have multiple changes.

Thanks a lot for working on this as it is an important issue.

…sting

…pi-compatible-testing

NullByte08 · 2020-04-08T10:25:59Z

@rt4914 Please review. I have run all the test files individually and all at once also. All tests are successful.

rt4914 · 2020-04-09T10:35:21Z

@NullByte08 Please don'e forget to assign it to correct reviewer, because the assign section was containing your name, I though that you are still working on this.
Read this: https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section

rt4914

There are still some test cases which are failing and we never use SystemClock.sleep(1000).

Actually the best approach to finish this PR soon is to split this PR into 3-4 different PRs and making sure that 4-5 packages are fixed in each PR.

rt4914 · 2020-04-09T11:47:19Z

app/src/main/java/org/oppia/app/settings/profile/ProfileEditActivityPresenter.kt

@@ -86,4 +86,8 @@ class ProfileEditActivityPresenter @Inject constructor(
  private fun getProfileEditViewModel(): ProfileEditViewModel {
    return viewModelProvider.getForActivity(activity, ProfileEditViewModel::class.java)
  }
+
+  fun handleOnRestoreSavedInstanceState(){
+    activity.title=editViewModel.profileName


Nit: activity.title = editViewModel.profileName

rt4914 · 2020-04-09T11:47:54Z

app/src/sharedTest/java/org/oppia/app/home/HomeActivityTest.kt

@@ -161,6 +161,8 @@ class HomeActivityTest {
    getApplicationDependencies()
    oppiaClock.setCurrentTimeMs(MORNING_TIMESTAMP)
    launch<HomeActivity>(createHomeActivityIntent(internalProfileId)).use {
+      onView(withId(R.id.home_recycler_view)).perform(scrollToPosition<RecyclerView.ViewHolder>(0))
+


Remove this blank line

rt4914 · 2020-04-09T11:48:30Z

app/src/sharedTest/java/org/oppia/app/profile/PinPasswordActivityTest.kt

@@ -117,7 +120,8 @@ class PinPasswordActivityTest {
        userId
      )
    ).use {
-      onView(withId(R.id.input_pin)).perform(typeText("123"))
+      onView(withId(R.id.input_pin)).perform(typeText("123"), closeSoftKeyboard())
+      SystemClock.sleep(1000)


We never use this because this sleep can actually hide the actual issue that might be happening in PR.

rt4914 · 2020-04-09T11:48:37Z

app/src/sharedTest/java/org/oppia/app/profile/PinPasswordActivityTest.kt

@@ -283,6 +289,7 @@ class PinPasswordActivityTest {
      onView(withText(context.getString(R.string.admin_settings_submit))).perform(click())
      onView(withText(context.getString(R.string.pin_password_close))).perform(click())
      onView(withId(R.id.input_pin)).perform(typeText("321"))
+      SystemClock.sleep(1000)


Ditto. Remove this.

rt4914 · 2020-04-15T09:51:09Z

This is finished via #960 #963 #965

NullByte08 and others added 3 commits March 20, 2020 17:39

Merge pull request #1 from oppia/develop

21b4588

updating

Merge pull request #2 from oppia/develop

20af3fe

update

Tests made compatible for HDPI devices

d762755

NullByte08 requested a review from rt4914 April 3, 2020 22:18

NullByte08 commented Apr 7, 2020

View reviewed changes

app/src/sharedTest/java/org/oppia/app/settings/profile/ProfileEditActivityTest.kt Outdated Show resolved Hide resolved

NullByte08 commented Apr 7, 2020

View reviewed changes

app/src/sharedTest/java/org/oppia/app/settings/profile/ProfileEditActivityTest.kt Outdated Show resolved Hide resolved

NullByte08 commented Apr 7, 2020

View reviewed changes

app/src/sharedTest/java/org/oppia/app/topic/revision/TopicRevisionFragmentTest.kt Outdated Show resolved Hide resolved

NullByte08 commented Apr 7, 2020

View reviewed changes

app/src/sharedTest/java/org/oppia/app/topic/revision/TopicRevisionFragmentTest.kt Outdated Show resolved Hide resolved

NullByte08 closed this Apr 7, 2020

NullByte08 reopened this Apr 7, 2020

Merge branch 'develop' into hdpi-compatible-testing

ae17ddd

rt4914 assigned NullByte08 Apr 7, 2020

NullByte08 and others added 5 commits April 8, 2020 15:18

Tests made compatible for HDPI devices commit 2

9913eae

Merge remote-tracking branch 'origin/develop' into hdpi-compatible-te…

ce2b28f

…sting

Merge branch 'develop' into hdpi-compatible-testing

aa2ae1c

Merge branch 'develop' into hdpi-compatible-testing

500dbef

Merge remote-tracking branch 'origin/hdpi-compatible-testing' into hd…

a723297

…pi-compatible-testing

NullByte08 assigned rt4914 and unassigned NullByte08 Apr 9, 2020

rt4914 suggested changes Apr 9, 2020

View reviewed changes

rt4914 assigned NullByte08 and unassigned rt4914 Apr 9, 2020

rt4914 closed this Apr 15, 2020

NullByte08 deleted the hdpi-compatible-testing branch April 15, 2020 12:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #935: Optimised test cases for HDPI devices #942

Fix #935: Optimised test cases for HDPI devices #942

NullByte08 commented Apr 3, 2020 •

edited

Loading

NullByte08 commented Apr 7, 2020

rt4914 commented Apr 7, 2020

NullByte08 commented Apr 8, 2020 •

edited

Loading

rt4914 commented Apr 9, 2020

rt4914 left a comment

rt4914 Apr 9, 2020

rt4914 Apr 9, 2020

rt4914 Apr 9, 2020

rt4914 Apr 9, 2020

rt4914 commented Apr 15, 2020

Fix #935: Optimised test cases for HDPI devices #942

Fix #935: Optimised test cases for HDPI devices #942

Conversation

NullByte08 commented Apr 3, 2020 • edited Loading

Explanation

Checklist

NullByte08 commented Apr 7, 2020

rt4914 commented Apr 7, 2020

NullByte08 commented Apr 8, 2020 • edited Loading

rt4914 commented Apr 9, 2020

rt4914 left a comment

Choose a reason for hiding this comment

rt4914 Apr 9, 2020

Choose a reason for hiding this comment

rt4914 Apr 9, 2020

Choose a reason for hiding this comment

rt4914 Apr 9, 2020

Choose a reason for hiding this comment

rt4914 Apr 9, 2020

Choose a reason for hiding this comment

rt4914 commented Apr 15, 2020

NullByte08 commented Apr 3, 2020 •

edited

Loading

NullByte08 commented Apr 8, 2020 •

edited

Loading