Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes part of #935: Optimised test cases for HDPI devices ( Packages M-P) #963

Merged
merged 26 commits into from
Apr 14, 2020
Merged

Fixes part of #935: Optimised test cases for HDPI devices ( Packages M-P) #963

merged 26 commits into from
Apr 14, 2020

Conversation

NullByte08
Copy link
Contributor

Explanation

Partially fixes #935

Tests made compatible for HDPI devices for packages mydownloads to profileprogress. All the tests pass successfully.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

NullByte08 and others added 21 commits March 20, 2020 17:39
@NullByte08
Merge pull request #1 from oppia/develop
21b4588 
updating
@NullByte08
Merge pull request #2 from oppia/develop
20af3fe 
update
@NullByte08
Tests made compatible for HDPI devices
d762755
@NullByte08
Tests made compatible for HDPI devices commit 2
9913eae
@NullByte08
Merge pull request #3 from oppia/develop
d411e55 
Update
@NullByte08
Merge remote-tracking branch 'origin/develop' into develop
af09f9e 
# Conflicts:
#	app/src/sharedTest/java/org/oppia/app/home/HomeActivityTest.kt
#	app/src/sharedTest/java/org/oppia/app/profile/AddProfileActivityTest.kt
@NullByte08
Tests made compatible for HDPI devices fixed packages A-H
dd46ae6
@NullByte08
Update ProfileEditActivity.kt
477250b
@NullByte08
Update ProfileEditActivityPresenter.kt
e79b084
@NullByte08
Update ProfileEditViewModel.kt
82c5124
@NullByte08
Update AddProfileActivityTest.kt
f8d3894
@NullByte08
Update AdminPinActivityTest.kt
a6ebf82
@NullByte08
Update PinPasswordActivityTest.kt
c7be7d8
@NullByte08
Update ProfileEditActivityTest.kt
5f4f6bf
@NullByte08
Update TopicRevisionFragmentTest.kt
2579da5
@NullByte08
Update NavigationDrawerTestActivityTest.kt
ba6e537
@NullByte08
Tests made compatible for HDPI devices for packages M-P
28d1e0d
@NullByte08
Update AdministratorControlsActivityTest.kt
5fd8af6
@NullByte08
Update AppVersionActivityTest.kt
28c9419
@NullByte08
Update HomeActivityTest.kt
c683929
@NullByte08
Update PinPasswordActivityTest.kt
9a4320e
@NullByte08 NullByte08 requested a review from rt4914 April 10, 2020 14:10
@NullByte08 NullByte08 assigned NullByte08 and rt4914 and unassigned NullByte08 Apr 10, 2020
rt4914
rt4914 suggested changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, the implementation is nice but you can optimise the code.

app/src/sharedTest/java/org/oppia/app/profile/PinPasswordActivityTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/app/profile/ProfileChooserFragmentTest.kt Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned NullByte08 and unassigned rt4914 Apr 13, 2020
@NullByte08
Copy link
Contributor Author

@rt4914 Changes done.

@NullByte08 NullByte08 assigned rt4914 and unassigned NullByte08 Apr 13, 2020
@NullByte08 NullByte08 requested a review from rt4914 April 13, 2020 06:15
rt4914
rt4914 approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914
Copy link
Contributor

rt4914 commented Apr 13, 2020

@NullByte08 Merge this PR with latest branch so that non_flaky_tests can pass.

@rt4914 rt4914 assigned NullByte08 and unassigned rt4914 Apr 13, 2020
@NullByte08
Copy link
Contributor Author

@rt4914 My branch is up-to-date with oppia/develop. But still, the non_flaky_tests are failing. Please have a look. Thanks.

@NullByte08 NullByte08 assigned rt4914 and unassigned NullByte08 Apr 13, 2020
@rt4914
Copy link
Contributor

rt4914 commented Apr 14, 2020

@rt4914 My branch is up-to-date with oppia/develop. But still, the non_flaky_tests are failing. Please have a look. Thanks.

Tests are failing because of an import missing in PinPasswordActivityTest. Once you fix this, it should pass.

@rt4914 rt4914 assigned NullByte08 and unassigned rt4914 Apr 14, 2020
@NullByte08 NullByte08 assigned rt4914 and unassigned NullByte08 Apr 14, 2020
@NullByte08
Copy link
Contributor Author

@rt4914 Changes done, please merge. Thanks.

rt4914
rt4914 approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit cb89c3c into oppia:develop Apr 14, 2020
@NullByte08 NullByte08 deleted the hdpi-tests-m-p branch April 14, 2020 14:41
@rt4914 rt4914 mentioned this pull request Apr 15, 2020
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimise app module test cases
2 participants
@NullByte08 @rt4914