Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9588] export logging types and values #858

Merged
merged 1 commit into from
Aug 25, 2023
Merged

[FSSDK-9588] export logging types and values #858

merged 1 commit into from
Aug 25, 2023

Conversation

raju-opti
Copy link
Contributor

Summary

  • Clients like the testapp and react-sdk needs logging types and values, currently they have to import it from deep paths from the lib directory. this PR will allow imports directly for the entrypoint. We will eventually remove lib directory from the published package bundle.

Test plan

  • All existing tests should pass

Issues

  • FSSDK-9588

@raju-opti raju-opti requested a review from a team as a code owner August 25, 2023 14:13
@coveralls
Copy link

Coverage Status

coverage: 90.46% (+0.006%) from 90.454% when pulling c96640d on raju/export-logger into 9ff2887 on master.

mikechu-optimizely
mikechu-optimizely approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea. Thanks. React will be able to log through to JS. LGTM.

@raju-opti raju-opti merged commit b1ef5b0 into master Aug 25, 2023
@raju-opti raju-opti deleted the raju/export-logger branch August 25, 2023 14:44
@mikechu-optimizely mikechu-optimizely mentioned this pull request Aug 29, 2023
Closed
raju-opti added a commit that referenced this pull request Oct 2, 2023
@raju-opti
Revert "[FSSDK-9588] export logging types and values (#858)"
bd078be 
This reverts commit b1ef5b0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@mikechu-optimizely mikechu-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raju-opti @coveralls @mikechu-optimizely