-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSSDK-9602] Bug Bash + JS SDK Follow-ons + Bag-o Updates #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikechu-optimizely
added
bug
Something isn't working
enhancement
New feature or request
labels
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prisma Cloud has found errors in this PR ⬇️
mikechu-optimizely
changed the title
[FSSDK-9602] Bug Bash + JS SDK followons
[FSSDK-9602] Bug Bash + JS SDK Follow-ons + Bag-o Updates
Aug 28, 2023
CI pipe failing until JS SDK beta5 is published to NPM, which includes export logging types and values. We're also working to make compatible the end-to-end test suite. |
mikechu-optimizely
pushed a commit
that referenced
this pull request
Sep 19, 2023
mikechu-optimizely
added a commit
that referenced
this pull request
Sep 21, 2023
* Quality of life updates picked from #210 * Add extra EOF lf * Correct dep versions * Lint fixes * Upgrade tough-cookie for CVE fix * Remove direct dep tough-cookie@4.1.3 --------- Co-authored-by: Mike Chu <mike.chu@optimizely.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues