add credits for third party libraries #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaszurkan-optimizely
requested review from
mikeproeng37 and
spencerwilson-optimizely
|
build |
mikeproeng37
suggested changes
Aug 16, 2018
There was a problem hiding this comment.
Can you include a line about first party code and move the 3rd party deps to Additional Code
https://github.com/optimizely/java-sdk/pull/204/files#diff-04c6e90faac2675aa89e2176d2eec7d8R95
mikeproeng37
suggested changes
Aug 22, 2018
README.md
Outdated
| @@ -114,3 +114,32 @@ If you choose to build the universal framework yourself, you can do so by runnin | |||
| ### Contributing | |||
| Please see [CONTRIBUTING](CONTRIBUTING.md). | |||
|
|
|||
| ### Credits | |||
|
|
|||
| First-party code (under OptimizelySDKCore/, OptimizelySDKDatafileManager/, OptimizelySDKEventDispatcher/, OptimizelySDKiOS/, OptimizelySDKShared/, OptimizelySDKTVOS/, OptimizelySDKUniversal/, OptimizelySDKUserProfile/, OptimizelySDKUserProfileService/, ) is copyright Optimizely, Inc. and contributors, licensed under Apache 2.0. | |||
There was a problem hiding this comment.
We no longer have code under OptimizelySDKUserProfile. I think we deprecated that in favor of OptimizelySDKUserProfileService
|
Can this be merged? |
AbdurRafay
pushed a commit
that referenced
this pull request
Sep 10, 2018
* master: this runs through the background and removes any experiments that are… (#302) Updating libraries based on SourceClear recommendation (#304) add credits for third party libraries (#299) # Conflicts: # OptimizelySDKUniversal/generated-frameworks/Release-iOS-universal-SDK/OptimizelySDKiOS.framework.zip # OptimizelySDKUniversal/generated-frameworks/Release-iOS-universal-SDK/OptimizelySDKiOS.framework/OptimizelySDKiOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.