Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added useCallback to getCurrentDecision in useDecision hook #184

Closed
wants to merge 1 commit into from
Closed

added useCallback to getCurrentDecision in useDecision hook #184

wants to merge 1 commit into from

Conversation

monahans
Copy link

@monahans monahans commented Oct 5, 2022

adding useCallback here fixed a few things:

  1. Bug: if you used multiple useDecision hooks with { autoUpdate: true }, the second one would not autoUpdate (you had to fully reload the app to get the decision to update)
  2. Before it was redefining getCurrentDecision on every rerender of the useDecision hook, which decreased performance

@mikechu-optimizely
Copy link
Contributor

This seems to relate to #196 and (now) internal ticket FSSDK-9624

@mikechu-optimizely mikechu-optimizely mentioned this pull request Dec 8, 2023
Closed
@junaed-optimizely
Copy link
Contributor

@monahans, this has been added in #273 with so many other improvements. Thanks for the suggestion. Closing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@monahans monahans

Labels
acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@monahans @mikechu-optimizely @junaed-optimizely