Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-10544] Refactor Hooks code + tests #273

Merged
merged 6 commits into from
Aug 15, 2024

Conversation

junaed-optimizely
Copy link
Contributor

@junaed-optimizely junaed-optimizely commented Aug 14, 2024

Summary

Test plan

  • Hook test suite is modified to fix some broken mocks and tests
  • Manual testing

Issues

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

No show-stoppers IMHO, but I have some curiosity questions 👇 DM me if it's easier.

src/hooks.ts Show resolved Hide resolved
src/hooks.ts Outdated Show resolved Hide resolved
src/hooks.ts Show resolved Hide resolved
src/hooks.spec.tsx Outdated Show resolved Hide resolved
src/hooks.spec.tsx Outdated Show resolved Hide resolved
src/hooks.spec.tsx Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants