Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.x: OKE provisioning on sub-compartment with support of custom identity domain. #785

Open
wants to merge 1 commit into
base: 5.x
Choose a base branch
from
Open

5.x: OKE provisioning on sub-compartment with support of custom identity domain. #785

wants to merge 1 commit into from

Conversation

thpham
Copy link
Contributor

@thpham thpham commented Jul 24, 2023

This PR relates to the issue #768.

OKE provisioning on sub-compartment which has no direct policy permission at the tenancy level.
This also support the case which has a custom identity domain in the sub-compartment instead of using the Default one at the tenancy level.

@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Jul 24, 2023
@thpham thpham changed the base branch from main to 5.x July 24, 2023 14:11
@thpham thpham force-pushed the issue-768-oke-subcompartment-iam branch 5 times, most recently from c338260 to 04ed750 Compare July 28, 2023 12:19
@oracle-contributor-agreement
Copy link

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Aug 1, 2023
@thpham thpham force-pushed the issue-768-oke-subcompartment-iam branch from 04ed750 to 77ce69f Compare August 7, 2023 07:59
@thpham thpham marked this pull request as ready for review August 7, 2023 07:59
@hyder
Copy link
Contributor

hyder commented Aug 7, 2023

Hi @thpham,

Thank you for your contribution. Can you also please add some documentation around usage? You can stick under identity: https://oracle-terraform-modules.github.io/terraform-oci-oke/guide/identity.html, we'll reorganize if necessary.

@thpham
Copy link
Contributor Author

thpham commented Aug 14, 2023

Hi @hyder,

thank you for your feedback ! I added some infos about the config and use case-. Would it be of for you ?

@thpham thpham changed the title OKE provisioning on sub-compartment with support of custom identity domain. 5.x: OKE provisioning on sub-compartment with support of custom identity domain. Sep 29, 2023
@thpham
Copy link
Contributor Author

thpham commented Nov 8, 2023 •
edited

@devoncrouse , what should I do with this PR ? , are you considering it and therefore I take the time to update it towards the merged main branch ? or you simply don't think it is interesting and therefore I close it and take another approach (fork)

@thpham thpham mentioned this pull request Nov 23, 2023
Merged
@thpham thpham force-pushed the issue-768-oke-subcompartment-iam branch from dbdd3f3 to 87c8c1d Compare December 8, 2023 17:44
@thpham
[iam] introduce iam_compartmen_id which define the top parent compart…
27b7726 
…ment for IAM resources when not at tenancy level

  - + describe usage of a Custom Identity Domain within an OCI subcompartment

Signed-off-by: Thomas Pham <thomas.pham@sicpa.com>
@thpham thpham force-pushed the issue-768-oke-subcompartment-iam branch from 87c8c1d to 27b7726 Compare December 8, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thpham @hyder