Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: networking module - bump to v3.6.0 #874

Merged
merged 1 commit into from
Nov 28, 2023
Merged

feat: networking module - bump to v3.6.0 #874

merged 1 commit into from
Nov 28, 2023

Conversation

thpham
Copy link
Contributor

@thpham thpham commented Nov 23, 2023

This PR is bumping the internal dependency on terraform-oci-vcn to its latest version v3.6.0 which integrates the following changes.

This also resolves issue #514.

@oracle-contributor-agreement Oracle Contributor Agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Nov 23, 2023
@thpham
feat: networking module - bump to v3.6.0
8290ebf 
Signed-off-by: Thomas Pham <thomas.pham@sicpa.com>
@hyder
Copy link
Contributor

hyder commented Nov 23, 2023

Would it be possible for you to sign the OCA? It will make collaborating with us so much faster.

@thpham
Copy link
Contributor Author

thpham commented Nov 23, 2023 •
edited

Hello @hyder,

Would it be possible for you to sign the OCA? It will make collaborating with us so much faster.

I already signed the OCA, proof is that I already created multiple PR here (example) and in other terraform modules. I think there is a problem with your bot.

@hyder
Copy link
Contributor

hyder commented Nov 23, 2023

I thought so. I'll check internally.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Nov 28, 2023
hyder
hyder approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@hyder hyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thank you for your patience

@hyder hyder merged commit 3d96325 into oracle-terraform-modules:main Nov 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyder hyder hyder approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thpham @hyder