Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enhanced cluster support #252

Merged
merged 44 commits into from
Jun 8, 2023
Merged

Add enhanced cluster support #252

merged 44 commits into from
Jun 8, 2023

Conversation

shyamradhakrishnan
Copy link
Member

@shyamradhakrishnan shyamradhakrishnan commented May 4, 2023 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #253

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 4, 2023
joekr
joekr requested changes May 15, 2023
View reviewed changes
Copy link
Member

@joekr joekr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think it is awesome! Some small questions and nit changes.

cloud/scope/managed_control_plane.go Show resolved Hide resolved
cloud/scope/managed_machine_pool.go Show resolved Hide resolved
config/crd/bases/infrastructure.cluster.x-k8s.io_ocimanagedcontrolplanes.yaml Show resolved Hide resolved
exp/api/v1beta2/conditions_consts.go Outdated Show resolved Hide resolved
templates/cluster-template-managed-flannel.yaml Show resolved Hide resolved
exp/api/v1beta1/ocivirtualmachinepool_types.go Outdated Show resolved Hide resolved
exp/api/v1beta1/ocivirtualmachinepool_types.go Outdated Show resolved Hide resolved
exp/api/v1beta2/ocivirtualmachinepool_types.go Outdated Show resolved Hide resolved
exp/api/v1beta2/ocivirtualmachinepool_types.go Outdated Show resolved Hide resolved
exp/controllers/ocivirtual_machinepool_controller.go Outdated Show resolved Hide resolved
joekr
joekr previously approved these changes May 25, 2023
View reviewed changes
cloud/scope/managed_control_plane.go Show resolved Hide resolved
cloud/scope/virtual_machine_pool.go Show resolved Hide resolved
exp/api/v1beta1/ocivirtualmachinepool_types.go Outdated Show resolved Hide resolved
test/e2e/managed_cluster_test.go Outdated Show resolved Hide resolved
joekr
joekr previously approved these changes May 25, 2023
View reviewed changes
joekr
joekr approved these changes May 30, 2023
View reviewed changes
docs/src/SUMMARY.md Show resolved Hide resolved
@shyamradhakrishnan shyamradhakrishnan force-pushed the add_enhanced_cluster_support branch 2 times, most recently from d8c3ccf to 660c0b7 Compare June 2, 2023 02:30
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
9c56f27
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
d7d888b
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
d134a10
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
4e411a3
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
eadde63
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
9c5a9a6
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
65b3049
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
cb6541f
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
66993b1
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
37a9ecf
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
1820ba8
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
9a75749
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
fcc6663
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
df03388
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
75c5b4e
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
67e644d
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
72eea79
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
0890889
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
56b6214
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
f4b31b7
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
e922efc
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
002c19b
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
b25a18a
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
2a0a553
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
df54f89
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
e5aa641
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
754cd8e
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
23ca9e8
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
2232398
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
5dcc400
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
83083e6
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
53243b5
@shyamradhakrishnan
Add support for enhanced cluster and virtual node pool
3d37ff7
joekr
joekr previously approved these changes Jun 2, 2023
View reviewed changes
@shyamradhakrishnan shyamradhakrishnan marked this pull request as ready for review June 7, 2023 05:49
@shyamradhakrishnan
Copy link
Member Author

e2e

------------------------------

Ran 7 of 26 Specs in 3651.677 seconds
SUCCESS! -- 7 Passed | 0 Failed | 0 Pending | 19 Skipped

@shyamradhakrishnan
Copy link
Member Author

unit test

?   	github.com/oracle/cluster-api-provider-oci	[no test files]
ok  	github.com/oracle/cluster-api-provider-oci/api/v1beta1	38.892s	coverage: 24.1% of statements
ok  	github.com/oracle/cluster-api-provider-oci/api/v1beta2	0.041s	coverage: 15.8% of statements
?   	github.com/oracle/cluster-api-provider-oci/cloud/config	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/metrics	[no test files]
ok  	github.com/oracle/cluster-api-provider-oci/cloud/ociutil	0.012s	coverage: 19.6% of statements
ok  	github.com/oracle/cluster-api-provider-oci/cloud/scope	240.132s	coverage: 75.5% of statements
?   	github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/base	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/base/mock_base	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/compute	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement/mock_computemanagement	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine/mock_containerengine	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/identity	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/loadbalancer	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/loadbalancer/mock_lb	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/vcn	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn	[no test files]
ok  	github.com/oracle/cluster-api-provider-oci/cloud/util	0.130s	coverage: 76.1% of statements
ok  	github.com/oracle/cluster-api-provider-oci/controllers	26.452s	coverage: 67.5% of statements
ok  	github.com/oracle/cluster-api-provider-oci/exp/api/v1beta1	27.296s	coverage: 18.7% of statements
ok  	github.com/oracle/cluster-api-provider-oci/exp/api/v1beta2	0.026s	coverage: 9.5% of statements
ok  	github.com/oracle/cluster-api-provider-oci/exp/controllers	1.155s	coverage: 56.7% of statements
?   	github.com/oracle/cluster-api-provider-oci/feature	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/version	[no test files]
go tool cover -func=coverage.out -o coverage.txt
go tool cover -html=coverage.out -o coverage.html

joekr
joekr requested changes Jun 7, 2023
View reviewed changes
test/e2e/config/e2e_conf.yaml Outdated Show resolved Hide resolved
@shyamradhakrishnan shyamradhakrishnan merged commit d3d1b85 into oracle:main Jun 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joekr joekr joekr approved these changes

Assignees

@shyamradhakrishnan shyamradhakrishnan

Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for OKE enhanced cluster and Virtual nodepool
2 participants
@shyamradhakrishnan @joekr