Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enhanced cluster support #252

Merged
Merged
Show file tree
Hide file tree
Changes from 43 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
9c56f27
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Apr 4, 2023
d7d888b
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Apr 5, 2023
d134a10
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Apr 5, 2023
4e411a3
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Apr 5, 2023
eadde63
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Apr 5, 2023
9c5a9a6
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Apr 5, 2023
65b3049
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Apr 5, 2023
cb6541f
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Apr 5, 2023
66993b1
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Apr 5, 2023
37a9ecf
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Apr 5, 2023
1820ba8
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Apr 5, 2023
9a75749
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Apr 5, 2023
fcc6663
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Apr 5, 2023
df03388
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Apr 5, 2023
75c5b4e
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Apr 5, 2023
67e644d
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Apr 5, 2023
72eea79
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Apr 5, 2023
cd807bd
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Apr 12, 2023
53401d7
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Apr 17, 2023
ad26b96
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan May 4, 2023
ce004d4
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan May 4, 2023
1aaee63
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan May 4, 2023
2090ff3
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan May 4, 2023
0890889
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan May 5, 2023
56b6214
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan May 16, 2023
f4b31b7
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan May 16, 2023
e922efc
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan May 16, 2023
002c19b
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan May 16, 2023
b25a18a
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan May 16, 2023
2a0a553
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan May 16, 2023
df54f89
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan May 16, 2023
e5aa641
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan May 19, 2023
754cd8e
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan May 19, 2023
23ca9e8
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan May 19, 2023
2232398
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan May 19, 2023
5dcc400
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan May 25, 2023
83083e6
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan May 30, 2023
53243b5
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan May 30, 2023
3d37ff7
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Jun 2, 2023
bbafdcb
Add support for image lookup
shyamradhakrishnan Jun 7, 2023
d23247c
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Jun 7, 2023
1a9b778
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Jun 7, 2023
9110aab
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Jun 7, 2023
41d0b7f
Add support for enhanced cluster and virtual node pool
shyamradhakrishnan Jun 7, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,7 @@ generate-e2e-templates: $(KUSTOMIZE)
$(KUSTOMIZE) build $(OCI_TEMPLATES)/v1beta2/cluster-template-managed-cluster-identity --load-restrictor LoadRestrictionsNone > $(OCI_TEMPLATES)/v1beta2/cluster-template-managed-cluster-identity.yaml
$(KUSTOMIZE) build $(OCI_TEMPLATES)/v1beta2/cluster-template-cluster-identity --load-restrictor LoadRestrictionsNone > $(OCI_TEMPLATES)/v1beta2/cluster-template-cluster-identity.yaml
$(KUSTOMIZE) build $(OCI_TEMPLATES)/v1beta2/cluster-template-windows-calico --load-restrictor LoadRestrictionsNone > $(OCI_TEMPLATES)/v1beta2/cluster-template-windows-calico.yaml
$(KUSTOMIZE) build $(OCI_TEMPLATES)/v1beta2/cluster-template-managed-virtual --load-restrictor LoadRestrictionsNone > $(OCI_TEMPLATES)/v1beta2/cluster-template-managed-virtual.yaml

.PHONY: test-e2e-run
test-e2e-run: generate-e2e-templates $(GINKGO) $(ENVSUBST) ## Run e2e tests
Expand Down
33 changes: 33 additions & 0 deletions cloud/scope/managed_control_plane.go
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,8 @@ func (s *ManagedControlPlaneScope) GetOrCreateControlPlane(ctx context.Context)
}
}

clusterType := getOKEClusterTypeFromSpecType(controlPlaneSpec)

details := oke.CreateClusterDetails{
Name: common.String(s.GetClusterName()),
CompartmentId: common.String(s.OCIClusterAccessor.GetCompartmentId()),
Expand All @@ -177,6 +179,7 @@ func (s *ManagedControlPlaneScope) GetOrCreateControlPlane(ctx context.Context)
EndpointConfig: endpointConfig,
ClusterPodNetworkOptions: podNetworks,
KmsKeyId: controlPlaneSpec.KmsKeyId,
Type: clusterType,
}

if controlPlaneSpec.ImagePolicyConfig != nil {
Expand Down Expand Up @@ -216,6 +219,22 @@ func (s *ManagedControlPlaneScope) GetOrCreateControlPlane(ctx context.Context)
return s.getOKEClusterFromOCID(ctx, clusterId)
}

func getOKEClusterTypeFromSpecType(controlPlaneSpec infrav2exp.OCIManagedControlPlaneSpec) oke.ClusterTypeEnum {
if controlPlaneSpec.ClusterType != "" {
switch controlPlaneSpec.ClusterType {
case infrav2exp.BasicClusterType:
return oke.ClusterTypeBasicCluster
break
case infrav2exp.EnhancedClusterType:
return oke.ClusterTypeEnhancedCluster
break
default:
break
}
}
return ""
shyamradhakrishnan marked this conversation as resolved.
Show resolved Hide resolved
}

// GetOKECluster tries to lookup a control plane(OKE cluster) based on ID/Name and returns the
// cluster if it exists,
func (s *ManagedControlPlaneScope) GetOKECluster(ctx context.Context) (*oke.Cluster, error) {
Expand Down Expand Up @@ -546,6 +565,8 @@ func (s *ManagedControlPlaneScope) UpdateControlPlane(ctx context.Context, okeCl
KeyDetails: s.getKeyDetails(),
}
}
clusterType := getOKEClusterTypeFromSpecType(controlPlaneSpec)
details.Type = clusterType
updateClusterRequest := oke.UpdateClusterRequest{
ClusterId: okeCluster.Id,
UpdateClusterDetails: details,
Expand Down Expand Up @@ -633,6 +654,18 @@ func (s *ManagedControlPlaneScope) getSpecFromActual(cluster *oke.Cluster) *infr
}
}
}
if cluster.Type != "" {
switch cluster.Type {
case oke.ClusterTypeBasicCluster:
spec.ClusterType = infrav2exp.BasicClusterType
break
case oke.ClusterTypeEnhancedCluster:
spec.ClusterType = infrav2exp.EnhancedClusterType
break
default:
break
}
}
shyamradhakrishnan marked this conversation as resolved.
Show resolved Hide resolved
return &spec
}

Expand Down
2 changes: 1 addition & 1 deletion cloud/scope/managed_machine_pool.go
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ func (m *ManagedMachinePoolScope) SetListandSetMachinePoolInstances(ctx context.
providerIDList := make([]string, 0)
for _, instance := range nodePool.Nodes {
if instance.LifecycleState == oke.NodeLifecycleStateActive {
providerIDList = append(providerIDList, fmt.Sprintf("oci://%s", *instance.Id))
providerIDList = append(providerIDList, *instance.Id)
shyamradhakrishnan marked this conversation as resolved.
Show resolved Hide resolved
}
}
m.OCIManagedMachinePool.Spec.ProviderIDList = providerIDList
Expand Down
Loading